Fix different charset #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinratinaud
force-pushed
the
fix_different_charset
branch
from
35fb14b to
a70c15f
Compare
martinratinaud
force-pushed
the
fix_different_charset
branch
from
a70c15f to
f229fdf
Compare
|
@Ndpnt do you have any idea why there is a lint problem? I have the same on my local but can not figure out why as package is correctly installed |
and created the corresponding issue in their repo node-fetch/fetch-charset-detection#247
|
As discussed with @Ndpnt yesterday, I will merge this without former approval but with oral approval. I had to bypass the eslint error by disabling As I managed to create a reproducible environment, I created an issue on their repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #935
The
.text()function is not trying to detect encoding anymore since version 2The new way to handle that kind of encoding is here for v3