This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
New GPS #82
Merged
New GPS #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cc and logic/wait_launch.cc to implement new functionality.
| @@ -88,6 +88,9 @@ bool GPS::initialize() | |||
| } | |||
| this->logger->log("Serial connection started."); | |||
|
|
|||
| this->logger->log("Setting GPS to pedestrian mode"); | |||
There was a problem hiding this comment.
The problem here could be that the GPS is also initialized when in safe mode, and this could be a problem. The pedestrian mode should be probably set by the main script, or at least, if the main script enters in safe mode, should be able to set the airborne model. Something like bool set_safe_mode() {...} or something like that.
|
This seems pretty fine by me. Maybe it would be better to avoid any type of reference to the GPS mode in the main logic, but I guess it's fine as it is. Still lots of testing left, but I'm merging the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I'm opening this pull request, to track all possible issues and small polishing left. I could do some of it if you can't. This should fix #77. Maybe, we could also add implementations for #29, #34, #63, and #70, since they are GPS related. Most of them are pretty straightforward.
What do you think, @cruzeneko?
Also, check my comments on your last commit. The pull request is pretty much finished, only small details left. Thanks for your work!!