Skip to content

Fix: use different query for add-on ddl - #303

Open
santipalenque wants to merge 2 commits into
mainfrom
fix/add-on-dropdown-fix
Open

Fix: use different query for add-on ddl#303
santipalenque wants to merge 2 commits into
mainfrom
fix/add-on-dropdown-fix

Conversation

@santipalenque

@santipalenque santipalenque commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

as part of https://app.clickup.com/t/9014802374/86bat8h0n

Summary by CodeRabbit

  • New Features

    • Added generalized add-on type selectors for standard and Formik-integrated forms.
    • Add-on options now display clear names rather than raw result data.
    • Updated data retrieval to use the add-on types endpoint.
    • Updated selector entry points and release version.
  • Breaking Changes

    • Replaced the former summit-specific selector exports with generalized add-on type selector names.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@santipalenque, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b0a066ce-23b4-4676-8ff7-072146e9a68d

📥 Commits

Reviewing files that changed from the base of the PR and between 2ad9b5d and 026ed56.

📒 Files selected for processing (8)
  • package.json
  • src/components/index.js
  • src/components/mui/__tests__/addon-type-select.test.js
  • src/components/mui/__tests__/mui-formik-addon-type-select.test.js
  • src/components/mui/addon-type-select.js
  • src/components/mui/formik-inputs/mui-formik-addon-type-select.js
  • src/utils/query-actions.js
  • webpack.common.js
📝 Walkthrough

Walkthrough

The pull request renames summit-specific addon selectors to addon type selectors, updates option mapping to use addon names, changes the query endpoint, and updates Formik integration, exports, Webpack entries, package version, and tests.

Changes

Addon type selector

Layer / File(s) Summary
Addon type selector core
src/utils/query-actions.js, src/components/mui/addon-type-select.js
The selector now queries the all-summits add-on-types endpoint. It uses each add-on name as the option value and label.
Formik and package wiring
src/components/mui/formik-inputs/mui-formik-addon-type-select.js, src/components/index.js, webpack.common.js, package.json
The Formik wrapper, public exports, Webpack entries, and package version now use the addon type selector names and paths.
Selector test updates
src/components/mui/__tests__/addon-type-select.test.js, src/components/mui/__tests__/mui-formik-addon-type-select.test.js
Tests now use addon objects and the renamed MUI and Formik components. Formik placeholder and error behavior coverage remains in place.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating the add-on dropdown to use a different query.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch fix/add-on-dropdown-fix
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/add-on-dropdown-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/components/mui/__tests__/addon-type-select.test.js (1)

52-60: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Assert the option mapping in this test.

The test named "renders options returned by querySummitAddons" only checks that the query was called. It would pass if r.name were ignored or mapped to the wrong value. Open the select and assert that Addon Alpha and Addon Beta render as the option labels and values.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/mui/__tests__/addon-type-select.test.js` around lines 52 - 60,
Update the test “renders options returned by querySummitAddons” to open the
rendered Select after the query resolves, then assert that options labeled and
valued “Addon Alpha” and “Addon Beta” are present. Keep the existing
querySummitAddons invocation assertion while verifying the returned addon name
mapping.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/components/mui/__tests__/addon-type-select.test.js`:
- Around line 52-60: Update the test “renders options returned by
querySummitAddons” to open the rendered Select after the query resolves, then
assert that options labeled and valued “Addon Alpha” and “Addon Beta” are
present. Keep the existing querySummitAddons invocation assertion while
verifying the returned addon name mapping.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c1ceee9-2896-428b-a4be-7cf66312bcb6

📥 Commits

Reviewing files that changed from the base of the PR and between 43f0d8c and e52c822.

📒 Files selected for processing (7)
  • src/components/index.js
  • src/components/mui/__tests__/addon-type-select.test.js
  • src/components/mui/__tests__/mui-formik-addon-type-select.test.js
  • src/components/mui/addon-type-select.js
  • src/components/mui/formik-inputs/mui-formik-addon-type-select.js
  • src/utils/query-actions.js
  • webpack.common.js

@santipalenque
santipalenque force-pushed the fix/add-on-dropdown-fix branch from 2ad9b5d to 026ed56 Compare August 3, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant