Fix: use different query for add-on ddl - #303
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe pull request renames summit-specific addon selectors to addon type selectors, updates option mapping to use addon names, changes the query endpoint, and updates Formik integration, exports, Webpack entries, package version, and tests. ChangesAddon type selector
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/mui/__tests__/addon-type-select.test.js (1)
52-60: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAssert the option mapping in this test.
The test named
"renders options returned by querySummitAddons"only checks that the query was called. It would pass ifr.namewere ignored or mapped to the wrong value. Open the select and assert thatAddon AlphaandAddon Betarender as the option labels and values.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/mui/__tests__/addon-type-select.test.js` around lines 52 - 60, Update the test “renders options returned by querySummitAddons” to open the rendered Select after the query resolves, then assert that options labeled and valued “Addon Alpha” and “Addon Beta” are present. Keep the existing querySummitAddons invocation assertion while verifying the returned addon name mapping.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/mui/__tests__/addon-type-select.test.js`:
- Around line 52-60: Update the test “renders options returned by
querySummitAddons” to open the rendered Select after the query resolves, then
assert that options labeled and valued “Addon Alpha” and “Addon Beta” are
present. Keep the existing querySummitAddons invocation assertion while
verifying the returned addon name mapping.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0c1ceee9-2896-428b-a4be-7cf66312bcb6
📒 Files selected for processing (7)
src/components/index.jssrc/components/mui/__tests__/addon-type-select.test.jssrc/components/mui/__tests__/mui-formik-addon-type-select.test.jssrc/components/mui/addon-type-select.jssrc/components/mui/formik-inputs/mui-formik-addon-type-select.jssrc/utils/query-actions.jswebpack.common.js
2ad9b5d to
026ed56
Compare
as part of https://app.clickup.com/t/9014802374/86bat8h0n
Summary by CodeRabbit
New Features
Breaking Changes