Add navigation buttons to scene graph node "..."-menu #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that can be reused
And fix shift-click focus
|
I tried it out and it works as expected 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new component for the navigation buttons (focus, fly-to, jump, frame) and reuses them in the scene menu popout that can be opened per scene graph node. See example:
This makes it easier to navigate to a scene graph node in the Scene or Exoplanets menu. Previously one had to search for the same node in the OriginPicker/Navigation menu
Breaking these buttons into more general components also lead to some improvement in terms of consistent behavior for the same feature across the UI. Previously, the "Focus" code was duplicated and implemented in two different ways, for example.