Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/texturewriter stb #101

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

WeirdRubberDuck
Copy link
Contributor

@WeirdRubberDuck WeirdRubberDuck commented Oct 6, 2023

  • Update stb_image version
  • Add a STB texture writer, that can save textures to disk (supported formats: jpg, jpeg, png, bmp, tga. HDR is left out for now, se comment)
  • Add a test to the test suite, that already erxisted but not actually compiled

Used in OpenSpace PR: OpenSpace/OpenSpace#2912

Copy link
Member

@alexanderbock alexanderbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. reliably getting:

86>stb_imaged.lib(stb_image.obj) : error LNK2005: stbi_load_from_memory already defined in assimp-vc143-mtd.lib(Assimp.obj)
86>stb_imaged.lib(stb_image.obj) : error LNK2005: stbi_load_from_callbacks already defined in assimp-vc143-mtd.lib(Assimp.obj)
86>stb_imaged.lib(stb_image.obj) : error LNK2005: stbi_load already defined in assimp-vc143-mtd.lib(Assimp.obj)
86>stb_imaged.lib(stb_image.obj) : error LNK2005: stbi_load_from_file already defined in assimp-vc143-mtd.lib(Assimp.obj)
86>stb_imaged.lib(stb_image.obj) : error LNK2005: stbi_load_16_from_memory already defined in assimp-vc143-mtd.lib(Assimp.obj)

When trying to compile

src/io/texture/texturewriterstb.cpp Outdated Show resolved Hide resolved
src/io/texture/texturewriterstb.cpp Show resolved Hide resolved
src/io/texture/texturewriterstb.cpp Outdated Show resolved Hide resolved
@WeirdRubberDuck
Copy link
Contributor Author

Hmm.. reliably getting:

86>stb_imaged.lib(stb_image.obj) : error LNK2005: stbi_load_from_memory already defined in assimp-vc143-mtd.lib(Assimp.obj)
86>stb_imaged.lib(stb_image.obj) : error LNK2005: stbi_load_from_callbacks already defined in assimp-vc143-mtd.lib(Assimp.obj)
86>stb_imaged.lib(stb_image.obj) : error LNK2005: stbi_load already defined in assimp-vc143-mtd.lib(Assimp.obj)
86>stb_imaged.lib(stb_image.obj) : error LNK2005: stbi_load_from_file already defined in assimp-vc143-mtd.lib(Assimp.obj)
86>stb_imaged.lib(stb_image.obj) : error LNK2005: stbi_load_16_from_memory already defined in assimp-vc143-mtd.lib(Assimp.obj)

When trying to compile

Eek, I got those now too when doing a completely clean build. Will have to check out howto handle the duplicated dependency

@alexanderbock
Copy link
Member

I think this might have been fixed with the recent AssImp update. Not getting the linker errors anymore

58>openspace-ui-launcher.vcxproj -> A:\openspace\OpenSpace\build\apps\OpenSpace\ext\launcher\RelWithDebInfo\openspace-ui-launcher.lib
58>Done building project "openspace-ui-launcher.vcxproj".
59>------ Build started: Project: OpenSpace, Configuration: RelWithDebInfo x64 ------
59>main.cpp
59>LINK : A:\openspace\OpenSpace\bin\RelWithDebInfo\OpenSpace.exe not found or not built by the last incremental link; performing full link
59>   Creating library A:/openspace/OpenSpace/build/apps/OpenSpace/RelWithDebInfo/OpenSpace.lib and object A:/openspace/OpenSpace/build/apps/OpenSpace/RelWithDebInfo/OpenSpace.exp
59>OpenSpace.vcxproj -> A:\openspace\OpenSpace\bin\RelWithDebInfo\OpenSpace.exe
59>													Deploying Qt libraries	Adding manifest...
========== Build: 59 succeeded, 0 failed, 15 up-to-date, 0 skipped ==========
========== Build completed at 16:33 and took 02:06.401 minutes ==========

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants