-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close meetings from inside #3869
Conversation
client-side:
|
As far as I understand the
|
So long, so good. We need a test, what is missing here. @Elblinator pls test and @bastianjoel pls review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only apply if the meeting is locked from the inside...
Orga-level > Committee-detail:
- in the three dot menu > Hide "Public template", "Duplicate" and "export"
- Relevant for committee admins (who are not meeting admins): Hide the "edit option"
- Relevant for superadmins (who are not meeting admins):
- id the edit meeting view is opened then disable all meeting specific info besides the Superadmin settings
Orga-level > account-list > multi-select:
- select account > "Set/remove meeting ..." > The locked meeting is still in that list and selectable, please also hide the locked meetings from that list
I was not able to test the meeting-level. So I still need to do that
I worked on the CR. Introduced some changes for the committee-meeting-preview and the 'Set/remove meetings' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only for superadmins:
in the committee detail view the edit option for closed meetings should still be visible even if the superadmin is not a meeting admin
Okay, updated the PR to allow superadmins to see meeting-edit even if not in the meeting. |
client/src/app/gateways/repositories/meeting-repository.service.ts
Outdated
Show resolved
Hide resolved
client/src/app/site/pages/organization/pages/dashboard/dashboard.subscription.ts
Outdated
Show resolved
Hide resolved
…lides-client into 3622-closed-meetings
I have updated the way to get the meeting membership. I now use groups. So no need to load the long user_ids list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs some discussion and a green light from @emanuelschuetze
Resolve #3622
Needs:
Draft version with setting, dashboard, meeting list, committee detail changes, and disable setting for templates