-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make duplicate-from mandatory, if 'required_duplicate_from' is set #3851
Make duplicate-from mandatory, if 'required_duplicate_from' is set #3851
Conversation
the issue from the autoupdate |
but please fix the tests |
I think, for the tests this needs the backend and meta pr merged. |
A change request:
Some requirements were not documented and now need some implementing in this PR:
|
If committee manager and require_duplicate_from set, the cm is not allowed to clone/duplicate and set template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue I've found:
- Meeting creation with or without the new function activated creates two error messages in the console. The creation works, but the creation mask isn't closed after saving it. Tried it as superadmin and committee admin. Doesn't worked properly for both admins.
Reproduction as superadmin:
- open committee > create a committee
- open dev-console
- create a meeting in the committee -> error messages will appear and the creation doesn't closed automatically.
What should happen:
- Creation mask should close itself by saving it and open the committee detail page
- error messages should not appear in console
Please change the texts of the new function from
- "Activate require templates for creating a meeting" to 'Enable meeting creation from templates only'
- 'If this setting is active committee-admins can only create meetings from public meeting templates, to enable these admins to create a meeting you need to create a template meeting first' to 'If this setting is activated, public meeting templates must have been created, as committee administrators can only create meetings based on public templates.'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loading bugs are gone, but the text ajdustments need to be done. They are located in the general instance settings:
-
"Activate require templates for creating a meeting" to 'Enable meeting creation from templates only'
-
'If this setting is active committee-admins can only create meetings from public meeting templates, to enable these admins to create a meeting you need to create a template meeting first' to 'If this setting is activated, public meeting templates must have been created, as committee administrators can only create meetings based on public templates.'
Additionally:
If the setting is activated and a committee admin wants to create a meeting from templates, a non-essential element, a dash, is displayed in the 'Duplicate from' selection. I have circled these in red in the image below.
What should happen?
If the new setting is activated, committee admins should only see templates in the 'Duplicate from' selection, all other information can be deleted as it is unnecessary. Specifically: Please delete the dash option.
Rename the labels. |
Please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MSoeb changes were made and I will dismiss his CR
Are the AU and meta merges missing? |
Resolve #3804
Needs OpenSlides/openslides-backend#2524
and an updated autoupdate service