Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust projected motion/topic/election to new detail view #3693

Merged
merged 15 commits into from
Aug 22, 2024

Conversation

Elblinator
Copy link
Member

@Elblinator Elblinator commented May 22, 2024

closes #2729
closes #3992

@Elblinator Elblinator added the bug label May 22, 2024
@Elblinator Elblinator added this to the 4.2 milestone May 22, 2024
@Elblinator Elblinator marked this pull request as ready for review May 22, 2024 12:00
@bastianjoel bastianjoel removed their assignment May 24, 2024
@emanuelschuetze
Copy link
Member

needs rebase for final test

@Elblinator Elblinator requested review from emanuelschuetze and removed request for rrenkert June 3, 2024 07:40
@Elblinator Elblinator requested a review from MSoeb June 7, 2024 10:38
@bastianjoel bastianjoel removed their assignment Jul 23, 2024
@Elblinator Elblinator closed this Aug 2, 2024
@Elblinator Elblinator deleted the 2729-call-detail_scss branch August 2, 2024 10:43
@Elblinator Elblinator restored the 2729-call-detail_scss branch August 2, 2024 10:49
@Elblinator Elblinator reopened this Aug 2, 2024
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A) PR didn't work. New motions can't be created. The action is interrupted with a error in snackbar and console. Therefor it's not possible to test

errors:
image

image

Repro:

  1. open a meeting
  2. open motions
  3. create a new motion. try to save it.

B) Please edit the font style of H2 heading. Font weight should be 700 in the projector to fit the font size in the motion. Even if it wasn't part of the original issue, we should change this so that the appearance between motion and projection is identical.

@Elblinator Elblinator requested a review from MSoeb August 13, 2024 06:24
@Elblinator Elblinator assigned MSoeb and unassigned Elblinator Aug 13, 2024
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to create a new motion, but it doesn't work. Saving is not possible. A snackbar and a console error appears.

Snackbar error: Ein unbekannter Fehler ist aufgetreten.

Console error:
image

@Elblinator Elblinator requested a review from MSoeb August 20, 2024 06:15
@Elblinator Elblinator assigned Elblinator and MSoeb and unassigned MSoeb and Elblinator Aug 20, 2024
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall fine.

Note: During testing I've got two error messages by reloading the instance login page.

  1. By opening the instance for the first time, I got a snackbar error with 'Fehler: Presenter server_time does not exist.'
  2. Additionally an error appears in the console which appears again by reloading the login page. Error message: Error: Operator has not fully loaded yet.

I've spoken with @m-schieder and @Elblinator about them. Both errors can't be reproduced by them. Also errors should not appear after merging. It seems to a something related to test instance.

@MSoeb MSoeb merged commit 648d67d into OpenSlides:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Appearance of several detail-views part 2 Adjust projector view to new detail-view
6 participants