Implement new database reader and writer #2833
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackend into database_read_write
| for get_many_request in get_many_requests | ||
| } | ||
|
|
||
| # TODO create one transaction from db |
There was a problem hiding this comment.
Concerning this TODO: I was under the impression that all read and write calls for one action (and sub-actions) needed to be part of the same transaction in order to allow for accurate locking. Generating it per read call seems wrong then. Is that false?
| "last_login": None, | ||
| "organization_management_level": None, | ||
| "meeting_ids": [1, 2, 3], | ||
| "organization_id": 1, |
There was a problem hiding this comment.
Where's the orga id coming from?
Comment on lines
+88
to
+104
| def test_too_many_mapped_fields( | ||
| db_connection: Connection, db_cur: Cursor, reader: ExtendedDatabase | ||
| ) -> None: | ||
| """The reader should return just all fields.""" | ||
| setup_data(db_connection, db_cur, data) | ||
| fields = [f"field_{i}" for i in range(2000)] | ||
| response = reader.get(FQID, fields) | ||
| assert response == standard_response | ||
|
|
||
|
|
||
| def test_mapped_fields_not_exists( | ||
| db_connection: Connection, db_cur: Cursor, reader: ExtendedDatabase | ||
| ) -> None: | ||
| setup_data(db_connection, db_cur, data) | ||
| with pytest.raises(InvalidFormat) as e_info: | ||
| reader.get(FQID, ["field_that_doesnt_exist"]) | ||
| assert "A field does not exist in model table: " in e_info.value.msg |
There was a problem hiding this comment.
Why should these have different results?
| ) -> None: | ||
| request = [ | ||
| GetManyRequest("committee", [-1], ["name"]), | ||
| GetManyRequest("committee", [1], ["forwarding_user_id"]), |
| db_connection: Connection, db_cur: Cursor, reader: ExtendedDatabase | ||
| ) -> None: | ||
| request = [ | ||
| GetManyRequest("committeee", [1], ["name"]), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant for a more efficient communication and should not be merged as is.