Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust dev setup to match main repo #1489

Merged
merged 6 commits into from
Jan 10, 2023
Merged

Adjust dev setup to match main repo #1489

merged 6 commits into from
Jan 10, 2023

Conversation

jsangmeister
Copy link
Contributor

No description provided.

@jsangmeister jsangmeister added this to the 4.0 milestone Sep 28, 2022
@jsangmeister jsangmeister self-assigned this Sep 28, 2022
@jsangmeister jsangmeister marked this pull request as ready for review September 28, 2022 13:24
@jsangmeister
Copy link
Contributor Author

Needed for OpenSlides/OpenSlides#6495

@r-peschke r-peschke self-requested a review October 5, 2022 12:12
r-peschke
r-peschke requested changes Oct 5, 2022
View reviewed changes
@r-peschke
Copy link
Member

The cause of the test failures may be the option --wait-for-client, used in the dev-dockerfile for backend and datastore. This is a mydebug-option, that waits for the attached debug client, which is the only way to debug the startup phase of a service.

@jsangmeister
Copy link
Contributor Author

Pushing this to 4.1 to not introduce big changes to the setup before the release, but will continue the work

@jsangmeister jsangmeister modified the milestones: 4.0, 4.1 Dec 13, 2022
@jsangmeister jsangmeister mentioned this pull request Dec 14, 2022
Merged
@jsangmeister jsangmeister force-pushed the dev-setup branch 4 times, most recently from bf73bf6 to e2ec566 Compare December 20, 2022 09:46
@jsangmeister
Copy link
Contributor Author

basically just changes the points mentioned in OpenSlides/OpenSlides#6495 (comment) - the previous changes of renaming the postgres container/db to *-test proved unnecessary since you cannot start the main setup and the backend setup in parallel anyway. For running backend tests etc. in the main setup, see OpenSlides/OpenSlides#6495 (comment).

@jsangmeister jsangmeister enabled auto-merge (squash) January 10, 2023 09:08
@jsangmeister jsangmeister merged commit 4cec82e into OpenSlides:main Jan 10, 2023
@jsangmeister jsangmeister deleted the dev-setup branch July 18, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrenkert rrenkert rrenkert approved these changes

@r-peschke r-peschke r-peschke approved these changes

Assignees

@jsangmeister jsangmeister

Labels
clean up feature high
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jsangmeister @r-peschke @rrenkert