Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting for closed meeting #2523

Merged
merged 18 commits into from
Jul 18, 2024
Merged

Add setting for closed meeting #2523

merged 18 commits into from
Jul 18, 2024

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Jul 11, 2024 •
edited

Closes #2497

TODO:

  • Add field to meeting.update and amend wiki
  • Disallow creation of a meeting that is both locked and a template
  • Update https://github.com/OpenSlides/OpenSlides/wiki/Permission-System
  • Wiki changes
  • Check if archiving and unarchiving still works even if the meeting is locked
  • Forbid meeting.clone for locked meetings
  • Add similar tests to those added to user.update to user.create
  • Ensure that the last admin from the locked meeting can not be removed in...
    • user.update
    • user.delete
    • participant.import?
    • Write tests for these
  • Fix actions that have failing tests
  • Look through new datastore calls

After consulting with @MSoeb, the get_user_related_models presenter was changed to only show data of meeting_internal models if the calling user either is in the meeting or the meeting is not locked

Updated https://github.com/OpenSlides/OpenSlides/wiki/Permission-System

@luisa-beerboom luisa-beerboom added this to the 4.2 milestone Jul 11, 2024
@luisa-beerboom luisa-beerboom self-assigned this Jul 11, 2024
@reiterl reiterl mentioned this pull request Jul 17, 2024
Merged
@luisa-beerboom
Copy link
Member Author

luisa-beerboom commented Jul 17, 2024 •
edited

TODO:

  • Discuss what shall be done to avoid permanently locked meeting edge case

@luisa-beerboom
Copy link
Member Author

TODO:

* [ ]  Discuss what shall be done to avoid **permanently locked meeting edge case**

After discussion issue #2528 has beeen opened for this case

@luisa-beerboom luisa-beerboom added this pull request to the merge queue Jul 18, 2024
Merged via the queue into OpenSlides:main with commit a55f527 Jul 18, 2024
5 checks passed
@luisa-beerboom luisa-beerboom deleted the 2497-new-setting-for-closed-meeting branch July 18, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-peschke r-peschke r-peschke approved these changes

Assignees

@luisa-beerboom luisa-beerboom

Labels
Curie feature Onnes
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

New setting for closed off meeting
2 participants
@luisa-beerboom @r-peschke