Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overwriting superadmin password on container start #2494

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Fix overwriting superadmin password on container start #2494

merged 7 commits into from
Jun 27, 2024

Conversation

peb-adr
Copy link
Member

@peb-adr peb-adr commented Jun 25, 2024

No description provided.

@peb-adr
Copy link
Member Author

peb-adr commented Jun 25, 2024

When the backend creates initial data on container start, the initial_import action will throw an exception if DS is not empty resulting in no organization data being overwritten.

However the follwing set_password action was still executed resulting in the superadmin password being reset.
Returning when catching the DS-not-empty exception fixes this.

@peb-adr peb-adr requested a review from r-peschke June 25, 2024 12:41
@peb-adr peb-adr added this to the 4.2 milestone Jun 25, 2024
@peb-adr peb-adr enabled auto-merge June 27, 2024 11:25
@peb-adr peb-adr added this pull request to the merge queue Jun 27, 2024
Merged via the queue into OpenSlides:main with commit 1f9692b Jun 27, 2024
5 checks passed
@peb-adr peb-adr deleted the init-data branch June 27, 2024 11:48
@peb-adr peb-adr mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-peschke r-peschke r-peschke approved these changes

Assignees

@peb-adr peb-adr

Labels
None yet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@peb-adr @r-peschke