Add 'allowCreate: false' to sp config and downgraded samlify #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rrenkert
commented
Apr 12, 2024
rrenkert
commented
- samlify sets an empty string as default for AllowCreate in authn request which leads to errors in some IdPs.
- samlify in 2.8.11 does not recognize the AllowCreate attribute so it is downgraded to 2.8.10 (allowCreate attribute not set correctly tngan/samlify#538)
* samlify sets an empty string as default for AllowCreate in authn request which leads to errors in some IdPs. * samlify in 2.8.11 does not recognize the AllowCreate attribute so it is downgraded to 2.8.10 (tngan/samlify#538)
peb-adr
approved these changes
Apr 12, 2024
peb-adr
added a commit
to peb-adr/openslides-auth-service
that referenced
this pull request
Apr 12, 2024
…des#343) * samlify sets an empty string as default for AllowCreate in authn request which leads to errors in some IdPs. * samlify in 2.8.11 does not recognize the AllowCreate attribute so it is downgraded to 2.8.10 (tngan/samlify#538) Co-authored-by: peb-adr <[email protected]>
peb-adr
added a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.