Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash with argon2 #170

Merged
merged 4 commits into from
Nov 30, 2023
Merged

hash with argon2 #170

merged 4 commits into from
Nov 30, 2023

Conversation

r-peschke
Copy link
Member

in addition to #167 the authlib for python also needs this change. See also OpenSlides/openslides-backend#2026

@r-peschke r-peschke added the critical Highest priority: This has to be done first. label Nov 29, 2023
@r-peschke r-peschke added this to the 4.1 milestone Nov 29, 2023
@r-peschke r-peschke self-assigned this Nov 29, 2023
reiterl
reiterl approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@reiterl reiterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the use of argon2 seems okay.

@r-peschke r-peschke removed the request for review from jsangmeister November 30, 2023 09:44
@r-peschke r-peschke merged commit 6a83d62 into OpenSlides:main Nov 30, 2023
3 checks passed
@r-peschke r-peschke deleted the BA2026_argon2_password_hash branch November 30, 2023 09:46
@jsangmeister jsangmeister mentioned this pull request Nov 30, 2023
Merged
m-schieder added a commit that referenced this pull request Dec 6, 2023
@m-schieder
Merge main into stable/4.0.x. Update 20231206
8378679 
* commit '86b7892abd10b4588b110548d88b16da6be3dbe2':
  Fix python hashing for deprecated passwords (#172)
  Ba2026 argon2 exception catched (#171)
  hash with argon2 (#170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsangmeister jsangmeister jsangmeister left review comments

@reiterl reiterl reiterl approved these changes

Assignees

@r-peschke r-peschke

Labels
critical Highest priority: This has to be done first.
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-peschke @reiterl @jsangmeister