Nhse 034 orkv.i57 fixcapability #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to make it easier to default in the future
Where change is not recent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capabilities are used to determine if a feature is safe to use, where this is determined by all nodes in the cluster being able to use that capability.
Capability calls are spread around the code. Some capabilities continue to be check, even though there is no support for a version sufficiently old to not support the capability.
There is a minimal cost to capability checks, but that cost is non-zero. There are also potential failure scenarios where there may be a fallback to the "wrong" capability.
Unify capability definitions, and where they are frequently requested and backwards-compatibility is no longer possible, hardcode them.