Nhse o32 upstream.d31 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle VCs that hash to 0 Because of a mistake (perhaps because phash/1 hashed to a range starting at 1, and phash2/1 now starts at 0) - special meaning was attributed to a hash of 0, which would means that updating hashtrees would not be handled correctly if the actual clock had a hash collision with 0. Special meaning now uses `none` not 0 - and 0 is handled as with any other hash value. * Add support for CH, OH of none, none Used in rehash in riak_kv_vnode - expected to be a neutral change i.e. CH, CH * Update comment * Clarify comments/types * Update GHA and workflow * Update erlang.yml
martinsumner
added a commit
that referenced
this pull request
Mar 19, 2025
* Handle VCs that hash to 0 (martinsumner#123) * Handle VCs that hash to 0 Because of a mistake (perhaps because phash/1 hashed to a range starting at 1, and phash2/1 now starts at 0) - special meaning was attributed to a hash of 0, which would means that updating hashtrees would not be handled correctly if the actual clock had a hash collision with 0. Special meaning now uses `none` not 0 - and 0 is handled as with any other hash value. * Add support for CH, OH of none, none Used in rehash in riak_kv_vnode - expected to be a neutral change i.e. CH, CH * Update comment * Clarify comments/types * Update GHA and workflow * Update erlang.yml * Update mockvnode_SUITE.erl
martinsumner
added a commit
that referenced
this pull request
Mar 20, 2025
* Nhse o32 upstream.d31 (#5) * Handle VCs that hash to 0 (martinsumner#123) * Handle VCs that hash to 0 Because of a mistake (perhaps because phash/1 hashed to a range starting at 1, and phash2/1 now starts at 0) - special meaning was attributed to a hash of 0, which would means that updating hashtrees would not be handled correctly if the actual clock had a hash collision with 0. Special meaning now uses `none` not 0 - and 0 is handled as with any other hash value. * Add support for CH, OH of none, none Used in rehash in riak_kv_vnode - expected to be a neutral change i.e. CH, CH * Update comment * Clarify comments/types * Update GHA and workflow * Update erlang.yml * Update mockvnode_SUITE.erl * Add back OTP 26 testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve OpenRiak/riak_kv#32.
Reviewed in martinsumner#124.
This PR stops treating a hash of 0 as a special case, the special case is now refereed to as
noneso that clocks that has to 0 are handled as with any other hash.