Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tr-TR: Fixed typos and added translations for the untranslated lines #2861

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

ozankaraali
Copy link
Contributor

Dear maintainers,

First of all thanks for maintaining this game. While I was playing, I have seen that Turkish translations had a lot of typos (and probably still there will be after this PR). But still I wanted to improve the translations and I have changed a couple of strings.

I tested in my game and some strings were English, even though I translated to Turkish, I don't know if OpenRCT2 supports unicode completely (I assume it is) but still if an experienced maintainer can take a look why, it would be a huge help.

Long story short, I am proposing an improvement for tr-TR since it is unmaintained for a while (yet still I cannot be a maintainer since I do not have enough time). Feel free to give feedback. Hope this helps.

Best,
Ozan

Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

tr-TR 414 1 382 (-15)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 116 2 1913
ca-ES 30 1 121
cs-CZ 435 0 248
da-DK 25 0 564
de-DE 2 1 358
en-US 3397 0 392
eo-ZZ 0 1 91
es-ES 0 1 306
fi-FI 6 1 117
fr-CA 3982 0 0
fr-FR 4 1 167
hu-HU 0 0 122
it-IT 22 1 344
ja-JP 351 1 607
ko-KR 0 1 196
nb-NO 25 0 483
nl-NL 2 13 480
pl-PL 193 1 408
pt-BR 0 1 150
ru-RU 1357 0 111
sv-SE 108 1 353
uk-UA 35 34 1139
vi-VN 273 3 3226
zh-CN 0 1 35
zh-TW 168 0 333

Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

tr-TR 414 1 382 (-15)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 116 2 1913
ca-ES 30 1 121
cs-CZ 435 0 248
da-DK 25 0 564
de-DE 2 1 358
en-US 3397 0 392
eo-ZZ 0 1 91
es-ES 0 1 306
fi-FI 6 1 117
fr-CA 3982 0 0
fr-FR 4 1 167
hu-HU 0 0 122
it-IT 22 1 344
ja-JP 351 1 607
ko-KR 0 1 196
nb-NO 25 0 483
nl-NL 2 13 480
pl-PL 193 1 408
pt-BR 0 1 150
ru-RU 1357 0 111
sv-SE 108 1 353
uk-UA 35 34 1139
vi-VN 273 3 3226
zh-CN 0 1 35
zh-TW 168 0 333

@Gymnasiast
Copy link
Member

Gymnasiast commented Jun 23, 2024

I tested in my game and some strings were English, even though I translated to Turkish, I don't know if OpenRCT2 supports unicode completely (I assume it is) but still if an experienced maintainer can take a look why, it would be a huge help.

OpenRCT2 supports Unicode, but the sprite font needs images to be drawn for every character. For Turkish, I added the missing ones a few years ago.

The reason some strings appear in English is not related to that, though. I looked at the file and currently, it’s translated up until STR_6527. However, the English translations currently goes to 6645, meaning there are almost 120 untranslated strings at the end. Besides that, some objects may lack translations. These are saved in another file in this repository.

@Gymnasiast Gymnasiast merged commit 0113d88 into OpenRCT2:master Jun 23, 2024
1 check passed
@ozankaraali
Copy link
Contributor Author

Thanks @Gymnasiast, maybe my game did not load correctly but it was lacking even the translation of "Haunted House" which the prior translation file renders. But you are correct, I found in the objects/tr-TR.json, Haunted House is in English. Either way, I believe this one fixes the most of the typos so it should be a better translation overall, on top of the existing. If I will have time later, I can try to extend that and thanks for merging and heads up about the objects.

Have a nice day,
Ozan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants