B #6472: Fix remove_off_hosts() #6473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return only the hosts in ON or UPDATE state (ONLINE or MONITORING_UPDATE). The original logic include the INIT state too, but there is a possibility that a host could become in ERROR state on failed INIT.
3 tasks
|
Hi @atodorov-storpool! Thanks for your input on the ticket and this PR. We've pursued a similar approach to yours, but with some adjustments. Our goal was to address this bug while preserving the original function's logic. However, your contribution shed light on an important issue with how different options were handled in the filtering process. We appreciate your contribution. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return only the hosts in ON or UPDATE state (ONLINE or MONITORING_UPDATE). The original logic include the INIT state too, but there is a possibility that a host could become in ERROR state on failed INIT.
Description
Branches to which this PR applies