Preliminary cleaning of the ./file dir under Win or if the flag noSync is set #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adrpo can you please check before merging? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Windows or if the --noSync flag is set the results files are moved/copied depending on the current value of the --clean flag. This means that if the --clean flag is = False the new test will find and copy to the result dir all the old files that are not overwritten by the new test itself.
To avoid this issue the best way is to clean the ./files directory when a new library test is started, independently from the value of the --clean flag.
This PR adds a preliminary clean of the ./files dir if the detected os is Windows or the flag noSync is set. Probably this is not necessary under linux if rsync is used to move the results files.