Logarithmic histograms for sum #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamSaw
approved these changes
Jan 21, 2025
| NUMBER_OF_BUCKETS) | ||
| col = backend.to_multi_transformable_collection(col) | ||
|
|
||
| return backend.flatten((_compute_frequency_histogram_per_key( |
There was a problem hiding this comment.
maybe extract and save results of _compute_frequency_histogram_per_key into variables to improve readability a little
There was a problem hiding this comment.
Good idea, thx, done
dvadym
commented
Jan 22, 2025
| NUMBER_OF_BUCKETS) | ||
| col = backend.to_multi_transformable_collection(col) | ||
|
|
||
| return backend.flatten((_compute_frequency_histogram_per_key( |
There was a problem hiding this comment.
Good idea, thx, done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of sum histogram uses linear buckets, namely 10^4 buckets between
[min_value, max_value]. In practice significant downsides where found:This PR inroduces logarithmic histograms for sum, which has the following buckets:
[buckets_for_negative] + [bucket_for_zero] + [buckets_for_positive].The number is assigned to Bucket(lower=get_lower(x), upper=get_upper(x))where:
for x > 0:
get_lower(x)- returns the number with 2 digits the same as in x, andget_upperis the next 2 digits number e.g.get_lower(123) == 120, get_upper(123) == 130,get_lower(0.1234) == 0.12,get_upper(0.1234) == 0.13The old histograms will be removed in future, when they will be used everywhere