Tuning for multiple columns part 3: Utility analysis for multiple aggregation #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvadym
changed the title
miracvbasaran
approved these changes
Sep 11, 2024
| if size1 is None or size2 is None or size1 != size2: | ||
| raise ValueError("If elements of min_sum_per_partition and " | ||
| "max_sum_per_partition are sequences, then" | ||
| " they must have the same length.") |
There was a problem hiding this comment.
nit: whitespace at the end of line like above
There was a problem hiding this comment.
This is a multi-line string, which doesn't contain new-lines, so it doens't matter where to put spaces.
dvadym
commented
Sep 12, 2024
| if size1 is None or size2 is None or size1 != size2: | ||
| raise ValueError("If elements of min_sum_per_partition and " | ||
| "max_sum_per_partition are sequences, then" | ||
| " they must have the same length.") |
There was a problem hiding this comment.
This is a multi-line string, which doesn't contain new-lines, so it doens't matter where to put spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces computing the utility analysis when there are several SUM aggregations. This covers cases when DP aggregations can be presented in the pseudo-SQL terms as
This contains the following changes:
min_sum_per_partition/max_sum_per_partitionwill be sequences (instead of floats)SumCombineris created for each sum (i.e. for each coordinate of the tuples in 1)CompoundCombinerkeeps track sparse representation as previously,SumCombinerreceives 2d array of values for each columns, but it extracts the value for the proper column.