Scale P and Q with L2 cache size for SVE #4397
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defaults in param.h now reflect an L2 size of 128KB, and that is scaled based on the actual size.
|
@martin-frbg , this is closer to what I was thinking previously, what do you think? I can see others have done similar in |
|
yes, for a specific cpu TARGET build I think the factor would have to be applied in common_param.h but I have limited brain capacity for that right now |
|
Thanks @martin-frbg, I'll look into it 😸 ! |
DhanusML
reviewed
Jan 19, 2024
| @@ -3517,13 +3517,13 @@ Until then, just keep it different than DGEMM_DEFAULT_UNROLL_N to keep copy rout | |||
| #define ZGEMM_DEFAULT_UNROLL_N 4 | |||
| #define ZGEMM_DEFAULT_UNROLL_MN 16 | |||
|
|
|||
| #define SGEMM_DEFAULT_P 128 | |||
| #define DGEMM_DEFAULT_P 160 | |||
| #define SGEMM_DEFAULT_P 30 | |||
There was a problem hiding this comment.
How were the default P and Q chosen for 128KB cache?
There was a problem hiding this comment.
#4381 demonstrated values that worked well for a 1MB L2 cache, so I divided that by 8.
If you have a more scientific approach, I'd be happy to hear it 😸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaults in param.h now reflect an L2 size of 128KB, and that is scaled based on the actual size.