Fix compilation with -Werror=format-security #3
Conversation
This patch avoids using fprintf with a string variable, i.e., fprintf(f, var). Such usage is discourage because if var can be attacker-controlled in any way, the application can be compromised. Therefore, -Werror=format-security complains about such usage. Better use fputs, which can't be misused, even though in this case the printed string is a constant.
|
IIRC I submitted this to a mailing list or so, but upstream has been dead for years so I don't think the patch ever got applied. EDIT: Ah hm no this file says it got "Committed upstream". And according to my local clone it was indeed in |
|
This seems to not be the only lost commit; 3a9a019 also was in |
|
Oh, it's probably as I suspected: this was not the master repository at one point and the last commits were not mirrored. |
|
So which is the master repo these days? I have two remotes in my checkout:
https://sourceforge.net/projects/osspd/ contains no indication that it is outdated. (That's what I set as the 'homepage' when I created the Debian package.) If this repo is official now, then I don't think there is a way that one could know this. Is there a better 'homepage' I could set? |
|
From https://sourceforge.net/projects/fuse:
I assume the master repo is this one and they simply forgot to update the page on SourceForge. |
|
Btw, here is the link proving that this was indeed committed upstream. |
|
Yeah, the repos seem to have diverged right after 4c6161d. |
|
SourceForge discussion continues in #6. |
@RalfJung Looks like your commit got lost: 097dc7b