Skip to content

Add return type and allow to override admin email preview templates #5162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tomasz-Silpion wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Add return type and allow to override admin email preview templates #5162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,9 @@ public function getLocaleOptions()
return Mage::app()->getLocale()->getOptionLocales();
}

public function getTemplateOptions()
public function getTemplateOptions(): array
{
return Mage_Core_Model_Email_Template::getDefaultTemplatesAsOptionsArray();
return Mage::getModel('core/email_template')->getDefaultTemplatesAsOptionsArray();
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a new model instance on every call to getTemplateOptions() is inefficient. Consider instantiating the model once and reusing it, or caching the result if the templates don't change frequently during a request.

Copilot uses AI. Check for mistakes.
}

public function getCurrentLocale()
Expand Down
Loading