Skip to content

Conversation

@Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Dec 15, 2025

Description (*)

FirstClassCallableRector got renamed to ArrayToFirstClassCallableRector

Related Pull Requests

  • see OpenMage/magento-lts#<issue_number>

Fixed Issues (if relevant)

  • fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

probably should bump the rector dependency to 2.2.12 because of this: rectorphp/rector-src@f632f73

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

FirstClassCallableRector got renamed to ArrayToFirstClassCallableRector
@github-actions
Copy link
Contributor

Test Results

963 tests   955 ✅  15s ⏱️
212 suites    8 💤
  1 files      0 ❌

Results for commit 77e6d40.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Test Results

963 tests   955 ✅  17s ⏱️
212 suites    8 💤
  1 files      0 ❌

Results for commit 54323bd.

♻️ This comment has been updated with latest results.

@Hanmac Hanmac marked this pull request as ready for review December 15, 2025 15:46
@github-actions github-actions bot added the composer Relates to composer.json label Dec 15, 2025
@sonarqubecloud
Copy link

@addison74 addison74 requested a review from Copilot December 15, 2025 18:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Rector configuration to reflect the renaming of FirstClassCallableRector to ArrayToFirstClassCallableRector in newer versions of Rector. The change also bumps the minimum Rector version requirement to 2.1.12.

  • Updates the class reference in the Rector configuration file
  • Bumps the minimum Rector version from 2.1.7 to 2.1.12 in composer.json

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
composer.json Updates minimum Rector version requirement to 2.1.12
.rector.php Renames FirstClassCallableRector to ArrayToFirstClassCallableRector to match upstream changes

@sreichel sreichel merged commit bf3b298 into main Dec 15, 2025
38 checks passed
@sreichel sreichel deleted the Hanmac-patch-ArrayToFirstClassCallableRector branch December 15, 2025 22:21
@sreichel sreichel added the bug label Dec 17, 2025
@sreichel sreichel added this to the 20.17.0 milestone Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug composer Relates to composer.json rector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants