-
-
Notifications
You must be signed in to change notification settings - Fork 449
[Core] add PsrLogger and support RFC 5424 log level #5144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Hanmac
wants to merge
8
commits into
OpenMage:main
Choose a base branch
from
b3-it:logPsrFix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8749071
[Core] add PsrLogger and support RFC 5424 log level
Hanmac a66c18a
fix style
Hanmac a7e7ebd
fix compatible with Varien_Object::debug
Hanmac 72a4448
fix missing newline
Hanmac 9e06542
~ reduce the log level range
Hanmac 06a42a5
apply suggestions
Hanmac f400438
~ check style
Hanmac 0a4d7bf
~ rector
Hanmac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * @copyright For copyright and license information, read the COPYING.txt file. | ||
| * @link /COPYING.txt | ||
| * @license Open Software License (OSL 3.0) | ||
| * @package Mage_Core | ||
| */ | ||
|
|
||
| use Psr\Log\InvalidArgumentException; | ||
| use Psr\Log\LoggerInterface; | ||
| use Psr\Log\LoggerTrait; | ||
| use Psr\Log\LogLevel; | ||
|
|
||
| /** | ||
| * Provides a PSR-3 LoggerInterface implementation that wraps Mage::log(). | ||
| * | ||
| * This class enables integration with PSR-3 compatible logging libraries and tools | ||
| * by forwarding log messages to the native Mage::log() method. It allows Magento | ||
| * modules and external libraries to use standardized logging practices within the | ||
| * OpenMage framework. | ||
| * | ||
| * @package Mage_Core | ||
| */ | ||
| class Mage_Core_Helper_PsrLogger extends Mage_Core_Helper_Abstract implements LoggerInterface | ||
| { | ||
| use LoggerTrait; | ||
|
|
||
| public function log($level, string|\Stringable $message, array $context = []): void | ||
| { | ||
| // unknown log level need to throw an InvalidArgumentException | ||
| $reflectionClass = new ReflectionClass(LogLevel::class); | ||
| if (!in_array($level, $reflectionClass->getConstants())) { | ||
| throw new InvalidArgumentException('Level "' . $level . '" is not defined, use one of: ' . implode(', ', $reflectionClass->getConstants())); | ||
| } | ||
|
|
||
| Mage::log((string) $message, $level, null, false, $context); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.