Replace php date functios with carbon

[sreichel]

Description (*)

Use rector to replace native date functions with carbon,

• see https://carbon.nesbot.com/docs/

(prepare to replace Zend_Date)

Related Pull Requests

• see rector: Replace php date functions, Varien_Date with Carbon date library #4463

[Copilot]

Pull request overview

Copilot reviewed 102 out of 102 changed files in this pull request and generated 11 comments.

Comments suppressed due to low confidence (1)

app/code/core/Mage/Index/Model/Observer.php:154

• Using Carbon::now()->sub() mutates the Carbon instance. This could cause issues if the $now variable is reused later. Consider using Carbon::now()->subSeconds(self::OLD_INDEX_EVENT_THRESHOLD_SECONDS) or calling copy() first to avoid mutation: $now->copy()->sub($dateInterval).

[addison74]

What would be the benefits? If Zend_Date is replaced, will the current extensions and modules still work or will they all need to be updated?

[sreichel]

This PR does not change any Varien_Date or Zend_Date related code.

I'd like to have consistent code over core and extension. Starting here.

With removing Zend_Date the is a little chance to break extension functionalty. Please note only a few metgods (5 according to docblocks) return Zend_Date. This should be easy to fix in extensions code.

Same for Zend_Date as methods paramter.

Lets discuss it when removing Zend_Date.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud