-
-
Notifications
You must be signed in to change notification settings - Fork 450
Updated cypress test #4975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated cypress test #4975
Conversation
- requires updated sample data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refactors Cypress end-to-end tests by modularizing route definitions, introducing shared helpers, and updating tests to the new structure.
- Split monolithic route config into granular backend/ frontend path modules.
- Added reusable helpers for page checks, clicks, and message assertions; updated tests to use them.
- Minor admin template improvement: added title attribute to “Add New Template” button.
Reviewed Changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 7 comments.
Show a summary per file
File | Description |
---|---|
cypress/support/openmage/frontend/paths.js | New frontend route map (replaces frontend part of old config). |
cypress/support/openmage/config/paths.js | Removed monolithic routes file; functionality split across backend/frontend modules. |
cypress/support/openmage/backend/system.js | New modular system routes (cache, design, email, myaccount, indexes, stores, variables, config). |
cypress/support/openmage/backend/sales.js | New modular sales routes (credit memo, invoice, order, shipment, transactions). |
cypress/support/openmage/backend/promo.js | New modular promo routes (catalog rules, quote rules). |
cypress/support/openmage/backend/newsletter.js | New modular newsletter routes (templates, queue, subscribers, reports). |
cypress/support/openmage/backend/dashboard.js | New dashboard route module. |
cypress/support/openmage/backend/customer.js | New customer routes (customers, groups, online). |
cypress/support/openmage/backend/cms.js | New CMS routes (blocks, pages, widgets) plus CMS-specific helpers. |
cypress/support/openmage/backend/catalog.js | New catalog routes (products, categories, search, sitemap, URL rewrite). |
cypress/support/openmage.js | Added utilities: check.pageElements, tools.clickAction/clickGridRow, message helpers; removed validation.saveAction. |
cypress/support/e2e.js | Switched imports to new modular backend/ frontend paths. |
cypress/support/commands.js | Updated adminGoToTestRoute signature; deprecated adminTestRoute; minor behavior changes. |
cypress/fixtures/example.json | Added sample fixture data. |
cypress/e2e/... (many backend tests) | Updated tests to use new route objects and helpers; added index/edit/new route coverage per area. |
cypress/e2e/openmage/frontend/newsletter-subscribe.cy.js | Updated to use new helpers and frontend path map. |
cypress/e2e/openmage/frontend/customer/account/create.cy.js | Updated to use new helpers and message assertions. |
app/design/adminhtml/default/default/template/newsletter/template/list.phtml | Added title attribute to "Add New Template" button for better UX and test targeting. |
…efactor # Conflicts: # cypress/support/openmage/_utils/tools.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 102 out of 103 changed files in this pull request and generated 8 comments.
|
Tests only ... merged |
Description (*)
Refactored all tests.
Basic Validation
Tests
... see test files ...
Current Work
How to use
ddev cypress-open -C .cypress.config.js
(browser), orddev cypress-run -C .cypress.config.js
(cli)Structure
Every page has a file for tests and a configuration file. E.g.
cypress/e2e/openmage/backend/cms/page.cy.js
Having all the tests in it.
cypress/support/openmage/backend/cms/page.js
For configuration of selectors for buttons and imput fields, title, url and funtions that are used in tests