rector: RemoveUnusedVariableInCatchRector

[sreichel]

See https://getrector.com/rule-detail/remove-unused-variable-in-catch-rector

[sreichel]

Pls ignore Sonar.

[Hanmac]

i'm more curious why the Exceptions aren't used, not even logged with Mage::logException?
And in most of the cases where i would throw a different exception, i would use the old exception as previous one.

Also since most of Mage core stuff does throw Throwable instead of Exception now,
wouldn't it be better to catch Throwable instead, or is that too dangerous?

[sreichel]

I think there is some space for improvements. Want to oen a new issue or discussion for that?

[sonarqubecloud]

Quality Gate failed

Failed conditions
8.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[sreichel]

Pls ignnore sonar.

(in free version it is not possible to adjust that limit)

[Copilot]

Pull Request Overview

This PR applies the Rector rule RemoveUnusedVariableInCatchRector to eliminate unused exception variables in catch blocks throughout the OpenMage codebase. This refactoring improves code cleanliness by removing variables that are caught but never used.

• Removes unused exception variables from catch blocks where the exception is not referenced
• Maintains exception variables where they are actually used (e.g., for logging, re-throwing, or error messages)
• Updates @throws annotations in one case to properly document exceptions that can be thrown

Reviewed Changes

Copilot reviewed 139 out of 139 changed files in this pull request and generated no comments.

File	Description
Various PHP files	Removed unused exception variables from catch blocks where exceptions are caught but not used
lib/Varien/Data/Tree/Db.php	Added @throws Exception annotation and renamed exception variables for clarity where they are actually used

[sonarqubecloud]

Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[sreichel]

Merged with one green.