rector: Replace php date functions, Varien_Date with Carbon date library

.phpstan.dist.baseline.neon

@@ -618,18 +618,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Adminhtml/controllers/Customer/System/Config/ValidatevatController.php
 
-		-
-			message: '#^Parameter \#2 \$timestamp of function date expects int\|null, array\|bool given\.$#'
-			identifier: argument.type
-			count: 1
-			path: app/code/core/Mage/Adminhtml/controllers/CustomerController.php
-
-		-
-			message: '#^Parameter \#2 \$value of method Zend_Controller_Response_Abstract\:\:setHeader\(\) expects string, array\|bool given\.$#'
-			identifier: argument.type
-			count: 1
-			path: app/code/core/Mage/Adminhtml/controllers/CustomerController.php
-
 		-
 			message: '#^Variable \$id in isset\(\) always exists and is not nullable\.$#'
 			identifier: isset.variable
@@ -708,18 +696,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php
 
-		-
-			message: '#^Parameter \#1 \$order of method Mage_Sales_Model_Resource_Order_Collection_Abstract\:\:setOrderFilter\(\) expects int\|Mage_Sales_Model_Order, array\<string, mixed\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php
-
-		-
-			message: '#^Parameter \#1 \$prefix of function uniqid expects string, int\<0, max\> given\.$#'
-			identifier: argument.type
-			count: 1
-			path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php
-
 		-
 			message: '#^Parameter \#2 \$callback of function array_filter expects \(callable\(mixed\)\: bool\)\|null, ''\\\\intval'' given\.$#'
 			identifier: argument.type
@@ -2574,24 +2550,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Core/Model/Config.php
 
-		-
-			message: '#^Binary operation "\+" between string and string results in an error\.$#'
-			identifier: binaryOp.invalid
-			count: 1
-			path: app/code/core/Mage/Core/Model/Date.php
-
-		-
-			message: '#^Binary operation "\-" between string and string results in an error\.$#'
-			identifier: binaryOp.invalid
-			count: 1
-			path: app/code/core/Mage/Core/Model/Date.php
-
-		-
-			message: '#^Property Mage_Core_Model_Date\:\:\$_systemOffset is never read, only written\.$#'
-			identifier: property.onlyWritten
-			count: 1
-			path: app/code/core/Mage/Core/Model/Date.php
-
 		-
 			message: '#^Call to an undefined method Mage_Core_Model_Resource_Design\:\:validate\(\)\.$#'
 			identifier: method.notFound
@@ -4296,12 +4254,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Rss/Helper/Data.php
 
-		-
-			message: '#^Property Mage_Rule_Model_Abstract\:\:\$_conditions \(Mage_Rule_Model_Condition_Combine\) in empty\(\) is not falsy\.$#'
-			identifier: empty.property
-			count: 1
-			path: app/code/core/Mage/Rule/Model/Abstract.php
-
 		-
 			message: '#^Call to an undefined method Mage_Rule_Model_Action_Interface\:\:getId\(\)\.$#'
 			identifier: method.notFound
@@ -4380,12 +4332,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Sales/Block/Recurring/Profiles.php
 
-		-
-			message: '#^Parameter \#1 \$order of method Mage_Sales_Model_Resource_Order_Collection_Abstract\:\:setOrderFilter\(\) expects int\|Mage_Sales_Model_Order, array given\.$#'
-			identifier: argument.type
-			count: 1
-			path: app/code/core/Mage/Sales/Model/Api2/Order.php
-
 		-
 			message: '#^Parameter \#2 \$code of method Mage_Api2_Model_Resource\:\:_critical\(\) expects int\|null, string given\.$#'
 			identifier: argument.type

.rector.php

@@ -84,7 +84,7 @@
             instanceOf: false,
             earlyReturn: false,
             strictBooleans: false,
-            carbon: false,
+            carbon: true,
             rectorPreset: false,
             phpunitCodeQuality: true,
             doctrineCodeQuality: false,

app/Mage.php

@@ -7,6 +7,8 @@
  * @package    Mage
  */
 
+use Carbon\Carbon;
+
 defined('DS') || define('DS', DIRECTORY_SEPARATOR);
 defined('PS') || define('PS', PATH_SEPARATOR);
 
@@ -830,7 +832,7 @@ public static function isInstalled($options = [])
             if (is_readable($localConfigFile)) {
                 $localConfig = simplexml_load_file($localConfigFile);
                 date_default_timezone_set('UTC');
-                if (($date = $localConfig->global->install->date) && strtotime((string) $date)) {
+                if (($date = $localConfig->global->install->date) && Carbon::parse((string) $date)->getTimestamp()) {
                     self::$_isInstalled = true;
                 }
             }

app/code/core/Mage/Admin/Model/Acl/Assert/Time.php

@@ -7,6 +7,8 @@
  * @package    Mage_Admin
  */
 
+use Carbon\Carbon;
+
 /**
  * Assert time for admin acl
  *
@@ -26,7 +28,7 @@ public function assert(
         ?Mage_Admin_Model_Acl_Resource $resource = null,
         $privilege = null
     ) {
-        return $this->_isCleanTime(time());
+        return $this->_isCleanTime(Carbon::now()->getTimestamp());
     }
 
     /**

app/code/core/Mage/Admin/Model/Resource/User.php

@@ -7,6 +7,8 @@
  * @package    Mage_Admin
  */
 
+use Carbon\Carbon;
+
 /**
  * ACL user resource
  *
@@ -47,7 +49,7 @@ public function recordLogin(Mage_Admin_Model_User $user)
         $adapter = $this->_getWriteAdapter();
 
         $data = [
-            'logdate' => Varien_Date::now(),
+            'logdate' => Carbon::now()->format(Carbon::DEFAULT_TO_STRING_FORMAT),
             'lognum'  => $user->getLognum() + 1,
         ];
 

app/code/core/Mage/Admin/Model/User.php

@@ -7,6 +7,8 @@
  * @package    Mage_Admin
  */
 
+use Carbon\Carbon;
+
 /**
  * Admin user model
  *
@@ -670,7 +672,7 @@ public function changeResetPasswordLinkToken($newResetPasswordLinkToken)
             throw Mage::exception('Mage_Core', Mage::helper('adminhtml')->__('Invalid password reset token.'));
         }
         $this->setRpToken($newResetPasswordLinkToken);
-        $currentDate = Varien_Date::now();
+        $currentDate = Carbon::now()->format(Carbon::DEFAULT_TO_STRING_FORMAT);
         $this->setRpTokenCreatedAt($currentDate);
 
         return $this;
@@ -690,17 +692,14 @@ public function isResetPasswordLinkTokenExpired()
             return true;
         }
 
-        $tokenExpirationPeriod = Mage::helper('admin')->getResetPasswordLinkExpirationPeriod();
-
-        $currentDate = Varien_Date::now();
-        $currentTimestamp = Varien_Date::toTimestamp($currentDate);
-        $tokenTimestamp = Varien_Date::toTimestamp($resetPasswordLinkTokenCreatedAt);
+        $currentTimestamp   = Carbon::now();
+        $tokenTimestamp     = Carbon::now()->setTimeFromTimeString($resetPasswordLinkTokenCreatedAt);
         if ($tokenTimestamp > $currentTimestamp) {
             return true;
         }
 
-        $hoursDifference = floor(($currentTimestamp - $tokenTimestamp) / (60 * 60));
-        if ($hoursDifference >= $tokenExpirationPeriod) {
+        $tokenExpirationPeriod = Mage::helper('admin')->getResetPasswordLinkExpirationPeriod();
+        if ($currentTimestamp->diffInDays($tokenTimestamp) >= $tokenExpirationPeriod) {
             return true;
         }
 
@@ -729,7 +728,8 @@ public function cleanPasswordsValidationData()
      */
     protected function _getDateNow($dayOnly = false)
     {
-        return Varien_Date::now($dayOnly);
+        $format = $dayOnly ? Mage_Core_Helper_Date::DATE_PHP_FORMAT : Mage_Core_Helper_Date::DATETIME_PHP_FORMAT;
+        return Carbon::now()->format($format);
     }
 
     /**

app/code/core/Mage/AdminNotification/Model/Feed.php

@@ -7,6 +7,8 @@
  * @package    Mage_AdminNotification
  */
 
+use Carbon\Carbon;
+
 /**
  * AdminNotification Feed model
  *
@@ -52,7 +54,7 @@ public function getFeedUrl()
      */
     public function checkUpdate()
     {
-        if (($this->getFrequency() + $this->getLastUpdate()) > time()) {
+        if (($this->getFrequency() + $this->getLastUpdate()) > Carbon::now()->getTimestamp()) {
             return $this;
         }
 
@@ -88,7 +90,7 @@ public function checkUpdate()
      */
     public function getDate($rssDate)
     {
-        return gmdate(Varien_Db_Adapter_Pdo_Mysql::TIMESTAMP_FORMAT, strtotime($rssDate));
+        return gmdate(Varien_Db_Adapter_Pdo_Mysql::TIMESTAMP_FORMAT, Carbon::parse($rssDate)->getTimestamp());
     }
 
     /**
@@ -118,7 +120,7 @@ public function getLastUpdate()
      */
     public function setLastUpdate()
     {
-        Mage::app()->saveCache(time(), 'admin_notifications_lastcheck');
+        Mage::app()->saveCache(Carbon::now()->getTimestamp(), 'admin_notifications_lastcheck');
         return $this;
     }
 

app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php

@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Customer account form block
  *
@@ -136,7 +138,7 @@ public function getCurrentStatus()
         $log = $this->getCustomerLog();
         if ($log->getLogoutAt()
             || !$log->getLastVisitAt()
-            || strtotime(Varien_Date::now()) - strtotime($log->getLastVisitAt()) > Mage_Log_Model_Visitor::getOnlineMinutesInterval() * 60
+            || Carbon::parse(Carbon::now()->format(Carbon::DEFAULT_TO_STRING_FORMAT))->getTimestamp() - Carbon::parse($log->getLastVisitAt())->getTimestamp() > Mage_Log_Model_Visitor::getOnlineMinutesInterval() * 60
         ) {
             return Mage::helper('customer')->__('Offline');
         }

app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php

@@ -8,6 +8,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Adminhtml dashboard google chart block
  *
@@ -211,7 +213,7 @@ public function generateChart(): array
                             $formats = Mage::app()->getLocale()->getTranslationList('datetime');
                             $format = $formats['yyMM'] ?? 'MM/yyyy';
                             $format = str_replace(['yyyy', 'yy', 'MM'], ['Y', 'y', 'm'], $format);
-                            $this->_axisLabels[$idx][$_index] = date($format, strtotime($_label));
+                            $this->_axisLabels[$idx][$_index] = Carbon::parse($_label)->format($format);
                             break;
                     }
                 }

app/code/core/Mage/Adminhtml/Block/Newsletter/Queue/Edit/Form.php

@@ -88,7 +88,7 @@ protected function _prepareForm()
 
         if ($queue->getQueueStartAt()) {
             $form->getElement('date')->setValue(
-                Mage::app()->getLocale()->date($queue->getQueueStartAt(), Varien_Date::DATETIME_INTERNAL_FORMAT),
+                Mage::app()->getLocale()->date($queue->getQueueStartAt(), Mage_Core_Helper_Date::DATETIME_INTERNAL_FORMAT),
             );
         }
 

app/code/core/Mage/Adminhtml/Block/Promo/Catalog/Edit/Tab/Main.php

@@ -138,15 +138,15 @@ protected function _prepareForm()
             'label'  => Mage::helper('catalogrule')->__('From Date'),
             'title'  => Mage::helper('catalogrule')->__('From Date'),
             'image'  => $this->getSkinUrl('images/grid-cal.gif'),
-            'input_format' => Varien_Date::DATE_INTERNAL_FORMAT,
+            'input_format' => Mage_Core_Helper_Date::DATE_INTERNAL_FORMAT,
             'format'       => $dateFormatIso,
         ]);
         $fieldset->addField('to_date', 'date', [
             'name'   => 'to_date',
             'label'  => Mage::helper('catalogrule')->__('To Date'),
             'title'  => Mage::helper('catalogrule')->__('To Date'),
             'image'  => $this->getSkinUrl('images/grid-cal.gif'),
-            'input_format' => Varien_Date::DATE_INTERNAL_FORMAT,
+            'input_format' => Mage_Core_Helper_Date::DATE_INTERNAL_FORMAT,
             'format'       => $dateFormatIso,
         ]);
 

app/code/core/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Main.php

@@ -193,15 +193,15 @@ protected function _prepareForm()
             'label'  => Mage::helper('salesrule')->__('From Date'),
             'title'  => Mage::helper('salesrule')->__('From Date'),
             'image'  => $this->getSkinUrl('images/grid-cal.gif'),
-            'input_format' => Varien_Date::DATE_INTERNAL_FORMAT,
+            'input_format' => Mage_Core_Helper_Date::DATE_INTERNAL_FORMAT,
             'format'       => $dateFormatIso,
         ]);
         $fieldset->addField('to_date', 'date', [
             'name'   => 'to_date',
             'label'  => Mage::helper('salesrule')->__('To Date'),
             'title'  => Mage::helper('salesrule')->__('To Date'),
             'image'  => $this->getSkinUrl('images/grid-cal.gif'),
-            'input_format' => Varien_Date::DATE_INTERNAL_FORMAT,
+            'input_format' => Mage_Core_Helper_Date::DATE_INTERNAL_FORMAT,
             'format'       => $dateFormatIso,
         ]);
 

app/code/core/Mage/Adminhtml/Block/Promo/Widget/Chooser/Daterange.php

@@ -56,7 +56,7 @@ protected function _toHtml()
         ) {
             $id = "{$key}_{$idSuffix}";
             $element = new Varien_Data_Form_Element_Date([
-                'format'   => Varien_Date::DATE_INTERNAL_FORMAT, // hardcode because hardcoded values delimiter
+                'format'   => Mage_Core_Helper_Date::DATE_INTERNAL_FORMAT, // hardcode because hardcoded values delimiter
                 'label'    => $label,
                 'image'    => $this->getSkinUrl('images/grid-cal.gif'),
                 'onchange' => "dateTimeChoose_{$idSuffix}()", // won't work through Event.observe()

app/code/core/Mage/Adminhtml/Block/Report/Config/Form/Field/YtdStart.php

@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Dashboard Year-To-Date Month and Day starts Field Renderer
  *
@@ -19,7 +21,7 @@ protected function _getElementHtml(Varien_Data_Form_Element_Abstract $element)
         $_months = [];
         for ($i = 1; $i <= 12; $i++) {
             $_months[$i] = Mage::app()->getLocale()
-                ->date(mktime(0, 0, 0, $i))
+                ->date(Carbon::now()->setHour(0)->setMinute(0)->setSecond(0)->setMonth($i))
                 ->get(Zend_Date::MONTH_NAME);
         }
 

app/code/core/Mage/Adminhtml/Block/Report/Grid.php

@@ -7,6 +7,8 @@
  * @package    Mage_Adminhtml
  */
 
+use Carbon\Carbon;
+
 /**
  * Adminhtml report grid block
  *
@@ -104,10 +106,11 @@ protected function _prepareColumns()
 
     /**
      * @return $this
+     * @throws Zend_Date_Exception
      */
     protected function _prepareCollection()
     {
-        $filter = $this->getParam($this->getVarNameFilter(), null);
+        $filter = $this->getParam($this->getVarNameFilter());
 
         if (is_null($filter)) {
             $filter = $this->_defaultFilter;
@@ -120,7 +123,13 @@ protected function _prepareCollection()
 
             if (!isset($data['report_from'])) {
                 // getting all reports from 2001 year
-                $date = new Zend_Date(mktime(0, 0, 0, 1, 1, 2001));
+                $date = new Zend_Date(Carbon::now()
+                    ->setHour(0)
+                    ->setMinute(0)
+                    ->setSecond(0)
+                    ->setMonth(1)
+                    ->setYear(2001));
+
                 $data['report_from'] = $date->toString($this->getLocale()->getDateFormat('short'));
             }
 

app/code/core/Mage/Adminhtml/Block/Report/Refresh/Statistics/Grid.php

@@ -35,7 +35,7 @@ protected function _getUpdatedAt($reportCode)
         return ($flag->hasData())
             ? Mage::app()->getLocale()->storeDate(
                 0,
-                new Zend_Date($flag->getLastUpdate(), Varien_Date::DATETIME_INTERNAL_FORMAT),
+                new Zend_Date($flag->getLastUpdate(), Mage_Core_Helper_Date::DATETIME_INTERNAL_FORMAT),
                 true,
             )
             : '';