Theme Mimic (luma style) #1682
Closed
Theme Mimic (luma style) #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While Mage_Catalog_Model_Resource_Product_Collection::addUrlRewrite() does respect any set storeId on the collection it's helper that does the actual work is hard-coded to the current active store.
* remove $timesUsed > 0 check to prevent duplicate entry * Prevent $timesUsed from going less than 0
#1149) * Suggestion to add some debugging to lockfile (to identify fileownership issues) Suggestion to add some debugging to lockfile (to identify fileownership issues) * keep the exception to bubble up Co-authored-by: Daniel Fahlke <[email protected]>
* Caching currencies * Caching currencies - base * Fix currency load - without additional SQL queries * Fix currency load - without additional SQL queries * Fix currency load - without additional SQL queries
* Delete the "get help for this page" link and translation item * Deleted all the store switcher hints that linked to old magento.com documentation * Removed unused code after store_switcher hints have been removed * Removed all the logic generating page helpers in the "system->config" section of the backend * Removed XPATH_HINT_KEY constant Co-authored-by: Fabrizio Balliano <[email protected]>
…ve without the admin realizing (#1544) * Only auto-detect the backend_type if none set yet If an attribute is user defined, the backend type is automatically set every time you save the attribute. If another backend_type was in use before, this breaks the attribute without the admin realizing it. We cannot have a different backend_type unless we also make the attribute is_user_defined = 0. Making the attribute non-user defined, might seam as the solution, but if you do this, the attribute becomes locked in the set and it cannot be removed anymore, so you're stuck with either e locked attribute that must remain in the set, or an attribute that will change backend_type on every save. My code change prevents the auto-changing of the backend_type. Only if there wasn't a backend_type before, will it now be auto-detected. * Prevent auto-changing of backend_type for API requests Same, but for API requests
Co-authored-by: Fabrizio Balliano <[email protected]>
…y modules still use (#1610) * reinstate stripped down getter and setter for to enabled third party module compatibility * Update app/code/core/Mage/Adminhtml/Helper/Data.php Co-authored-by: Ng Kiat Siong <[email protected]> * Update app/code/core/Mage/Adminhtml/Helper/Data.php Co-authored-by: Ng Kiat Siong <[email protected]> * Update app/code/core/Mage/Adminhtml/Helper/Data.php Co-authored-by: Ng Kiat Siong <[email protected]> Co-authored-by: ed <[email protected]> Co-authored-by: Ng Kiat Siong <[email protected]>
* Added a configuration flag to disable global search in adminhtml, also modified the templates to use the new flag. * Update system.xml "comment" remove from translation * Changed getStoreConfig to getStoreConfigFlag * changed getStoreConfig to getStoreConfigFlag Co-authored-by: Fabrizio Balliano <[email protected]>
github-actions
bot
added
Component: lib/Varien
|
I assume you are talking about OpenMage/OpenMage-Themes#1 things can take time, we have a lot to do, and are in most parts not paid for it. Iam closing this here because it is a duplicate of the linked one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on May 7th I published in OpenMage-Themes where I illustrated a complete and working thema inspired by the LUMA theme of magento 2
to date no one has checked it and made it available in the "repository" to make it immediately available to users who want to adopt it.
(I apologize for any incorrect terms and incorrect procedures but honestly I struggle to understand the correct way to present the questions and suggestions in the correct way according to the rules)