Skip to content

Commit

Permalink
Merge branch 'ocd' into 'master'
Browse files Browse the repository at this point in the history
Assorted nitpicks

See merge request OpenMW/openmw!4194
  • Loading branch information
Assumeru committed Jun 23, 2024
2 parents 7888a11 + c615601 commit 5cf809f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
4 changes: 0 additions & 4 deletions apps/openmw/mwlua/types/actor.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@

#include "apps/openmw/mwbase/environment.hpp"
#include "apps/openmw/mwworld/esmstore.hpp"
#include <components/esm3/loadclas.hpp>
#include <components/esm3/loadnpc.hpp>

#include "../context.hpp"

Expand Down Expand Up @@ -57,11 +55,9 @@ namespace MWLua
sol::table travelDests(lua, sol::create);
if (!rec.getTransport().empty())
{

int index = 1;
for (const auto& dest : rec.getTransport())
{

sol::table travelDest(lua, sol::create);

ESM::RefId cellId;
Expand Down
2 changes: 1 addition & 1 deletion apps/openmw/mwrender/ripplesimulation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ namespace MWRender
}
else
{
if (mMaxNumberRipples == 0)
if (mMaxNumberRipples <= 0)
return;

osgParticle::ParticleSystem::ScopedWriteLock lock(*mParticleSystem->getReadWriteMutex());
Expand Down
9 changes: 4 additions & 5 deletions files/settings-default.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -472,11 +472,10 @@ apply lighting to environment maps = false
# 'force per pixel lighting' is enabled.
lighting method = shaders compatibility

# Sets the bounding sphere multiplier of light sources if 'lighting method' is
# not 'legacy'. These are used to determine if an object should receive
# lighting. Higher values will allow for smoother transitions of light sources,
# but may carry a performance cost and requires a higher number of 'max lights'
# set.
# Sets the bounding sphere multiplier of light sources.
# The bounding sphere is used to determine if an object should receive lighting.
# Higher values will allow for smoother transitions of light sources,
# but may carry a performance cost and require a higher number of 'max lights' set.
light bounds multiplier = 1.65

# The distance from the camera at which lights fade away completely.
Expand Down

0 comments on commit 5cf809f

Please sign in to comment.