Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Example Jupyter Notebooks #644

Closed
wants to merge 30 commits into from
Closed

Conversation

szoppelt
Copy link

Summary

In the four example Jupyter notebooks, fix typo "time" to "times" in phase_info -> "initial_guesses"

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

Copy link
Contributor

@jkirk5 jkirk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output cells left behind in the Jupyter notebooks modified are causing the docs test to fail. I tried make a PR with a fix to your repo, see if that worked (or clear the notebook outputs and push it up on your end)

Removed jupyter output cells
@szoppelt
Copy link
Author

The output cells left behind in the Jupyter notebooks modified are causing the docs test to fail. I tried make a PR with a fix to your repo, see if that worked (or clear the notebook outputs and push it up on your end)

Yes this worked on my end. Do you want me to push the notebooks through again, or will it be ok?

@jkirk5
Copy link
Contributor

jkirk5 commented Jan 21, 2025

Yes this worked on my end. Do you want me to push the notebooks through again, or will it be ok?

It looks like somehow the output cells are back... can you try and delete them yourself and push? I'm not sure how they are still here, as far as I can tell we properly removed them and merged those changes into your branch

@szoppelt
Copy link
Author

Yes this worked on my end. Do you want me to push the notebooks through again, or will it be ok?

It looks like somehow the output cells are back... can you try and delete them yourself and push? I'm not sure how they are still here, as far as I can tell we properly removed them and merged those changes into your branch

I believe they are finally correct now.

@jkirk5
Copy link
Contributor

jkirk5 commented Jan 23, 2025

It appears that the issue this PR was intended to correct is no longer occurring with the latest version of Aviary, so this PR will be closed

@jkirk5 jkirk5 closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants