-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Example Jupyter Notebooks #644
Conversation
Replace Aviary example Jupyter notebooks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output cells left behind in the Jupyter notebooks modified are causing the docs test to fail. I tried make a PR with a fix to your repo, see if that worked (or clear the notebook outputs and push it up on your end)
Removed jupyter output cells
Yes this worked on my end. Do you want me to push the notebooks through again, or will it be ok? |
It looks like somehow the output cells are back... can you try and delete them yourself and push? I'm not sure how they are still here, as far as I can tell we properly removed them and merged those changes into your branch |
Add files via upload
…nal_flight_phases_2.ipynb
…aft_mission_optimization.ipynb
I believe they are finally correct now. |
It appears that the issue this PR was intended to correct is no longer occurring with the latest version of Aviary, so this PR will be closed |
Summary
In the four example Jupyter notebooks, fix typo "time" to "times" in phase_info -> "initial_guesses"
Related Issues
Backwards incompatibilities
None
New Dependencies
None