-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for legacy code defaults #628
Open
jkirk5
wants to merge
26
commits into
OpenMDAO:main
Choose a base branch
from
jkirk5:legacy_defaults
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleaned up GASP files to original status
created separate copy of configuration test data for models vs. conversion utility test
re-added accidentally deleted configuration test legacy input file
moved propeller tests to appropriate folder
Kenneth-T-Moore
approved these changes
Jan 22, 2025
Fix manifest for the propeller decks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reworked
fortran_to_aviary
to support default values and units that are separate from variable metadataNamedValues
formatFixed a bug where
fortran_to_aviary
tests were not actually testing anythingutils/tests/data
because files undermodels
are modified with additional variables added after conversionMoved some files that seem to only be used for converter tests (including engine deck conversion) into the
utils/test/data
directoryRenamed some example models to be more consistently named for better clarity
Related Issues
Backwards incompatibilities
None
New Dependencies
None