Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for legacy code defaults #628

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

jkirk5
Copy link
Contributor

@jkirk5 jkirk5 commented Dec 10, 2024

Summary

Reworked fortran_to_aviary to support default values and units that are separate from variable metadata

  • An incomplete list of defaults for each legacy code are provided in python files in NamedValues format
  • When converting an input file, all defaults are added to that file, to prevent a changed Aviary default from overwriting the expected default in the legacy code. Any values provided by the user in the input file overwrite defaults in the converted Aviary .csv
  • Fixed bug where variables in the "depreciated" list weren't being properly excluded from the "Unconverted Values" section
  • Removed support for mixed FLOPS/GASP/Aviary files. Only "valid" input files that are able to be successfully run using a legacy tool will be supported going forward
  • Verbosity utility runs at is no longer tied to verbosity specified for the model itself

Fixed a bug where fortran_to_aviary tests were not actually testing anything

  • Made new copies of expected .csv under utils/tests/data because files under models are modified with additional variables added after conversion

Moved some files that seem to only be used for converter tests (including engine deck conversion) into the utils/test/data directory

Renamed some example models to be more consistently named for better clarity

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@jkirk5 jkirk5 self-assigned this Dec 10, 2024
jkirk5 added 2 commits December 11, 2024 13:18
created separate copy of configuration test data for models vs. conversion utility test
Fix manifest for the propeller decks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants