Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed EOMs in ODEs for clarity #134

Merged
merged 3 commits into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aviary/mission/flops_based/ode/landing_ode.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def setup(self):
'aviary_options': options['aviary_options']}

self.add_subsystem(
'eoms',
'landing_eom',
FlareEOM(**kwargs),
promotes_inputs=[
Dynamic.Mission.FLIGHT_PATH_ANGLE, Dynamic.Mission.VELOCITY, Dynamic.Mission.MASS, Dynamic.Mission.LIFT,
Expand Down
2 changes: 1 addition & 1 deletion aviary/mission/flops_based/ode/takeoff_ode.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def setup(self):
'aviary_options': options['aviary_options']}

self.add_subsystem(
'eoms', TakeoffEOM(**kwargs),
'takeoff_eom', TakeoffEOM(**kwargs),
promotes_inputs=[
Dynamic.Mission.FLIGHT_PATH_ANGLE, Dynamic.Mission.VELOCITY, Dynamic.Mission.MASS, Dynamic.Mission.LIFT,
Dynamic.Mission.THRUST_TOTAL, Dynamic.Mission.DRAG, 'angle_of_attack'],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ def build_phase(self, aviary_options: AviaryValues = None):
phase.add_path_constraint(
'v_over_v_stall', lower=1.25, ref=2.0)

phase.add_boundary_constraint('eoms.forces_vertical', loc='initial', equals=0,
phase.add_boundary_constraint('takeoff_eom.forces_vertical', loc='initial', equals=0,
ref=100000)

return phase
Expand Down
2 changes: 1 addition & 1 deletion aviary/mission/gasp_based/ode/accel_ode.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def setup(self):
Dynamic.Mission.ALTITUDE_RATE] if analysis_scheme is AnalysisScheme.SHOOTING else []

self.add_subsystem(
"eom",
"accel_eom",
AccelerationRates(
num_nodes=nn,
analysis_scheme=analysis_scheme),
Expand Down
2 changes: 1 addition & 1 deletion aviary/mission/gasp_based/ode/ascent_ode.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def setup(self):
shooting_inputs = []

self.add_subsystem(
"eoms",
"ascent_eom",
AscentEOM(num_nodes=nn,
analysis_scheme=analysis_scheme),
promotes_inputs=[
Expand Down
2 changes: 1 addition & 1 deletion aviary/mission/gasp_based/ode/breguet_cruise_ode.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def setup(self):
# collect initial/final outputs
#
self.add_subsystem(
"eom",
"breguet_eom",
RangeComp(num_nodes=nn),
promotes_inputs=[
("cruise_distance_initial", "initial_distance"),
Expand Down
2 changes: 1 addition & 1 deletion aviary/mission/gasp_based/ode/climb_ode.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def setup(self):
lift_balance_group.linear_solver = om.DirectSolver(assemble_jac=True)

lift_balance_group.add_subsystem(
"eom",
"climb_eom",
ClimbRates(
num_nodes=nn,
analysis_scheme=analysis_scheme),
Expand Down
3 changes: 1 addition & 2 deletions aviary/mission/gasp_based/ode/descent_ode.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
from aviary.mission.gasp_based.ode.constraints.flight_constraints import \
FlightConstraints
from aviary.mission.gasp_based.ode.constraints.speed_constraints import SpeedConstraints
from aviary.mission.gasp_based.ode.descent_eom import DescentRates

from aviary.variable_info.enums import AnalysisScheme, SpeedType
from aviary.variable_info.variables import Dynamic
Expand Down Expand Up @@ -170,7 +169,7 @@ def setup(self):
lift_balance_group.linear_solver = om.DirectSolver(assemble_jac=True)

lift_balance_group.add_subsystem(
"eom",
"descent_eom",
DescentRates(
num_nodes=nn,
analysis_scheme=analysis_scheme),
Expand Down
6 changes: 3 additions & 3 deletions aviary/mission/gasp_based/ode/flight_path_ode.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def setup(self):
atol=1e-8, print_level=print_level)

self.add_subsystem(
"eoms",
"flight_path_eom",
FlightPathEOM(
num_nodes=nn,
ground_roll=self.options['ground_roll'],
Expand All @@ -205,7 +205,7 @@ def setup(self):
)

if not self.options['ground_roll']:
self.promotes('eoms', outputs=[
self.promotes('flight_path_eom', outputs=[
Dynamic.Mission.ALTITUDE_RATE, Dynamic.Mission.FLIGHT_PATH_ANGLE_RATE])

self.add_excess_rate_comps(nn)
Expand Down Expand Up @@ -261,7 +261,7 @@ def setup(self):
'core_aerodynamics',
'alpha_comp',
'prop_group',
'eoms',
'flight_path_eom',
'mass_trigger',
'SPECIFIC_ENERGY_RATE_EXCESS',
'ALTITUDE_RATE_MAX',
Expand Down
2 changes: 1 addition & 1 deletion aviary/mission/gasp_based/ode/groundroll_ode.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def setup(self):
src_indices=np.zeros(nn, dtype=int),
)

self.add_subsystem("eoms", GroundrollEOM(num_nodes=nn, analysis_scheme=analysis_scheme),
self.add_subsystem("groundroll_eom", GroundrollEOM(num_nodes=nn, analysis_scheme=analysis_scheme),
promotes=["*"])

self.add_subsystem("exec", om.ExecComp(f"over_a = velocity / velocity_rate",
Expand Down
2 changes: 1 addition & 1 deletion aviary/mission/gasp_based/ode/rotation_ode.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def setup(self):
promotes_outputs=["alpha"],
)

self.add_subsystem("eoms", RotationEOM(
self.add_subsystem("rotation_eom", RotationEOM(
num_nodes=nn, analysis_scheme=analysis_scheme), promotes=["*"])

ParamPort.set_default_vals(self)
Expand Down
Loading