Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in Fortran_to_Aviary.py #128

Merged
merged 4 commits into from
Feb 7, 2024
Merged

fix error in Fortran_to_Aviary.py #128

merged 4 commits into from
Feb 7, 2024

Conversation

xjjiang
Copy link
Contributor

@xjjiang xjjiang commented Feb 6, 2024

Summary

If users run fortran_to_aviary without specifying an output file, it runs into error.
If GASP data file has ARNGE(1) = 0., it runs into error.

This PR should fix both.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@xjjiang xjjiang requested a review from crecine February 6, 2024 17:50
Copy link
Contributor

@crecine crecine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this, I made a couple suggestions

aviary/utils/Fortran_to_Aviary.py Outdated Show resolved Hide resolved
aviary/utils/Fortran_to_Aviary.py Outdated Show resolved Hide resolved
aviary/utils/Fortran_to_Aviary.py Outdated Show resolved Hide resolved
@xjjiang xjjiang requested a review from johnjasa February 6, 2024 20:43
@johnjasa johnjasa enabled auto-merge February 7, 2024 21:20
@johnjasa johnjasa added this pull request to the merge queue Feb 7, 2024
Merged via the queue into OpenMDAO:main with commit ae60d5b Feb 7, 2024
7 checks passed
jkirk5

This comment was marked as duplicate.

@xjjiang xjjiang deleted the F2A branch February 8, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants