Fix MYFACES-4117 in JSF 2.2 #30415

volosied · 2024-12-14T01:19:26Z

I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

volosied · 2024-12-14T01:20:36Z

Commit for reference: https://github.com/apache/myfaces/commit/a5ecbb3657437e79ceb1702d35d6d714740ec213#diff-bbd193714a7a5f6f8534e2762eb571611c2fd671d68838f136247247b5062a02R141

LibbyBot · 2024-12-14T14:08:24Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

1 product code files were changed.
Please describe in a separate comment how you tested your changes.

volosied · 2024-12-16T13:47:54Z

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-16T13:55:47Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

4 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
1 product code files were changed.
Please describe in a separate comment how you tested your changes.

volosied · 2024-12-16T17:55:22Z

!build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-16T18:02:25Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

4 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
1 product code files were changed.
Please describe in a separate comment how you tested your changes.

dev/com.ibm.ws.jsf.2.2_fat/fat/src/com/ibm/ws/jsf22/fat/tests/JSF22ComponentRendererTests.java

....ibm.ws.jsf.2.2_fat/test-applications/JSF22ComponentRenderer.war/resources/myfaces4117.xhtml

...tRenderer.war/src/com/ibm/ws/jsf22/fat/componentrenderer/myfaces4117/TestFacesComponent.java

...ntRenderer.war/src/com/ibm/ws/jsf22/fat/componentrenderer/myfaces4117/TestFacesRenderer.java

volosied · 2024-12-18T16:16:31Z

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-18T16:24:48Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

4 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
1 product code files were changed.
Please describe in a separate comment how you tested your changes.

volosied · 2024-12-19T03:57:47Z

!build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2024-12-19T04:10:20Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

4 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
1 product code files were changed.
Please describe in a separate comment how you tested your changes.

Fix MYFACES-4117

a6b4408

volosied self-assigned this Dec 14, 2024

volosied added the release bug This bug is present in a released version of Open Liberty label Dec 14, 2024

volosied marked this pull request as draft December 14, 2024 01:19

volosied added in:Web Components team:Sirius labels Dec 14, 2024

LibbyBot added the CLA Signed label Dec 14, 2024

Create test for MyFaces-4117; use @FacesRenderer to render component

efe6bd4

volosied force-pushed the OLGH30414 branch from 8593439 to efe6bd4 Compare December 15, 2024 02:41

volosied requested a review from pnicolucci December 16, 2024 17:55

volosied marked this pull request as ready for review December 16, 2024 17:55