UpgradeHandler may not notify the application to read the initial data that sent along with the upgrade request. #30328
Conversation
|
#build |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_dB-V0bHHEe-Q24Sd2QdBoQ Target locations of links might be accessible only to IBM employees. |
pmd1nh
force-pushed
the
UpgradeHandler_May_Miss_Initial_Data
branch
from
f96ee7b to
e3d7006
Compare
|
#build #spawn.fullfat.buckets=io.openliberty.webcontainer.servlet.6.1.internal_fat,io.openliberty.webcontainer.servlet.6.0.internal_fat,com.ibm.ws.webcontainer.servlet.6.1_fat_toleration.lWAS,com.ibm.ws.webcontainer.servlet.6.0_fat_toleration.lWAS,com.ibm.ws.webcontainer_fat,com.ibm.ws.webcontainer.servlet.3.1_fat,com.ibm.ws.webcontainer.servlet.3.1_fat.2,com.ibm.ws.webcontainer.servlet.4.0_fat,com.ibm.ws.webcontainer_fat_part2,com.ibm.ws.webcontainer_fat_servlet31toleration,com.ibm.ws.webcontainer_fat_servlet31toleration_part2,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0_part2,com.ibm.ws.webcontainer_fat_lWAS,com.ibm.ws.webcontainer_fat_servlet31_webcontainerlWAS,com.ibm.ws.webcontainer.servlet.4.0_fat_toleration.3.0.lWAS,com.ibm.ws.transport.http_test Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
pmd1nh
force-pushed
the
UpgradeHandler_May_Miss_Initial_Data
branch
from
e3d7006 to
b9d4c8e
Compare
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_lcwZ0LLEEe-Q24Sd2QdBoQ Target locations of links might be accessible only to IBM employees. |
...bm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/channel/HttpDispatcherLink.java
Show resolved
Hide resolved
pmd1nh
changed the title
|
@pmd1nh the parent issue needs to be updated to use the release bug template. Thanks! |
| Tr.debug(tc, "close, CLOSE_NON_UPGRADED_STREAMS"); | ||
| } | ||
|
|
||
| // Save the remain upgrading and unread data into a VC's stateMap which will be consumed in the UpgradeInputByteBufferUtil.initialRead |
There was a problem hiding this comment.
Would this be better to just say "Save the remaining unread data"? I'm not following what upgrading vs unread data is.
| //If we encounter an exception here we need to return the 1 byte that we already have. | ||
| //Returned true immediately and the next read will catch the exception and propagate it properly | ||
| /* | ||
| * On a slow system/startup, data comes from the wire is faster than the channel can read/parse. |
There was a problem hiding this comment.
"On a slow system/startup, data comes from the wire faster than the channel can read/parse."
| * On a slow system/startup, data comes from the wire is faster than the channel can read/parse. | ||
| * If so, data needs to be read from the prepared buffer (set during the first initialRead()) instead of the wire. | ||
| * This happens mainly on the very first POST. | ||
| * this method is called down from the application readListener onDataAvailable() read. |
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).################################################################################################
fixed #30341