Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

30315 memory leak weak hashmap keys #30325

Draft
wants to merge 7 commits into
base: integration
Choose a base branch
from

Conversation

benjamin-confino
Copy link
Member

@benjamin-confino benjamin-confino commented Dec 3, 2024

Creates a unique object to serve as keys to annotation scanning caches, created and destroyed by an application metadata listener. This fixes a memory leak.

Fixes #30315

TODO!

[] Rebase on integration and run a build, once we get the POC vote this branch will be quite stale.

@benjamin-confino
Copy link
Member Author

benjamin-confino commented Dec 3, 2024

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

@LibbyBot
Copy link

LibbyBot commented Dec 3, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 7 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@benjamin-confino benjamin-confino force-pushed the 30315-memory-leak-weak-hashmap-keys branch from bafb50b to 889df79 Compare December 3, 2024 23:42
@benjamin-confino
Copy link
Member Author

benjamin-confino commented Dec 3, 2024

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@benjamin-confino benjamin-confino force-pushed the 30315-memory-leak-weak-hashmap-keys branch from 0afb837 to bafb50b Compare December 3, 2024 23:42
@LibbyBot
Copy link

LibbyBot commented Dec 3, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 8 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

1 similar comment
@LibbyBot
Copy link

LibbyBot commented Dec 3, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 8 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

LibbyBot commented Dec 4, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Hb_RwbH8Ee-Q24Sd2QdBoQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Dec 4, 2024

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?pipelineId=5d737a3e-1385-409b-8d6d-3fe145cc0a90 - Open Liberty Personal Build completed with errors/failures.

@benjamin-confino benjamin-confino force-pushed the 30315-memory-leak-weak-hashmap-keys branch from 889df79 to 4bc7ea2 Compare December 4, 2024 14:39
@benjamin-confino
Copy link
Member Author

benjamin-confino commented Dec 4, 2024

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Dec 4, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 8 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@benjamin-confino benjamin-confino force-pushed the 30315-memory-leak-weak-hashmap-keys branch 2 times, most recently from e4520af to e0f98b4 Compare December 5, 2024 21:23
@benjamin-confino
Copy link
Member Author

benjamin-confino commented Dec 5, 2024

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Dec 5, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 14 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@benjamin-confino benjamin-confino force-pushed the 30315-memory-leak-weak-hashmap-keys branch 2 times, most recently from 07d8f5c to a6da270 Compare December 6, 2024 10:35
@benjamin-confino
Copy link
Member Author

benjamin-confino commented Dec 6, 2024

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Dec 6, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 14 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@benjamin-confino benjamin-confino force-pushed the 30315-memory-leak-weak-hashmap-keys branch from a6da270 to 6d25ff6 Compare December 8, 2024 21:26
@benjamin-confino
Copy link
Member Author

benjamin-confino commented Dec 8, 2024

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Dec 8, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 14 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

tbitonti
tbitonti previously approved these changes Dec 10, 2024
@benjamin-confino
Copy link
Member Author

benjamin-confino commented Dec 10, 2024

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 16 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Please code review feature-related files, @OpenLiberty/delivery-approvers

@benjamin-confino benjamin-confino force-pushed the 30315-memory-leak-weak-hashmap-keys branch from 8d2b0f1 to 512d0bd Compare December 11, 2024 11:11
@benjamin-confino benjamin-confino marked this pull request as draft December 11, 2024 11:17
@benjamin-confino
Copy link
Member Author

All looking good, but we need a POC vote before we make the changes to the externals. Converting to a draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MemoryLeak in TargetCacheImpl_DataApps
3 participants