-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional tests for ddlGen that aligns with proposed doc #30157
Add additional tests for ddlGen that aligns with proposed doc #30157
Conversation
Make it easier in the future to add methods and customization. Allow for an alternative set of authentication data that does not change between databases using withAuthVariables
#libby - check headers |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=274b0373-feb7-43cc-b393-07b5b1ddabfb Target locations of links might be accessible only to IBM employees. |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=fc3519e5-a2cd-4fc4-b4ad-ed51aeed28cb Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Database rotation personal build: https://libh-proxy1.fyre.ibm.com/cognitive-dev/pipelineAnalysis.html?pipelineId=60ebf452-4fb8-4c53-bb05-80e91e4301eb Target locations of links might be accessible only to IBM employees. |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_YjDc4KJEEe-kGLEyqlUFUA Target locations of links might be accessible only to IBM employees. |
dev/fattest.simplicity/test/componenttest/topology/database/container/authDataServer.xml
Show resolved
Hide resolved
dev/fattest.simplicity/test/componenttest/topology/database/container/dataSourceServer.xml
Show resolved
Hide resolved
@@ -69,12 +68,19 @@ public static void setUp() throws Exception { | |||
DDLGenScriptResult result = DDLGenScript.build(server) | |||
.execute() | |||
.assertSuccessful() | |||
.assertDDLFile("application[DDLGenTestApp].module[DDLGenTestApp.war].databaseStore[java.comp.DefaultDataSource]_JakartaData.ddl") | |||
.assertDDLFile("application[DDLGenTestApp].databaseStore[TestDataSource]_JakartaData.ddl") | |||
.assertDDLFile("application[DDLGenTestApp].databaseStore[jdbc.TestDataSourceJndi]_JakartaData.ddl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we end up writing two separate files if the same dataSource is referenced by repositories where one references the jndiName and the other references its id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I'll add that test scenario in an additional pull request. My initial assumption is that they would go to different files, since we use the dataStore
attribute of @Repository
to create the databaseStore
config.id at runtime.
....data.internal_fat_ddlgen/publish/servers/io.openliberty.data.internal.fat.ddlgen/server.xml
Show resolved
Hide resolved
...lgen/test-applications/DDLGenTestApp/src/test/jakarta/data/ddlgen/web/DDLGenTestServlet.java
Show resolved
Hide resolved
#build - redo personal build after fixing prior build breaks |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1760c804-cdf7-4969-a38f-49ea5038a5e0 Target locations of links might be accessible only to IBM employees. |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=0aecc270-0021-4275-aebe-011ddd5d7d12 Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
1 similar comment
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Personal Database SOE: https://libh-proxy1.fyre.ibm.com/cognitive-dev/pipelineAnalysis.html?pipelineId=413ec17b-6719-484a-90f3-2e2ba75d7c9b Target locations of links might be accessible only to IBM employees. |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_gNXY4KPTEe-kGLEyqlUFUA Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Build Results: Pipeline: Passed successfully |
I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify
release bug
label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".
Refactors DatabaseContainerUtil to allow for more nuanced AuthData replacement.
Adds unit testing for DatabaseContainerUtil
Adds ddlGen tests for the following scenarios:
Tests align with proposed doc: OpenLiberty/docs#7468
While also testing additional persistence paradigms such as
@MappedSuperclass
and@Inheritance
in combination with ddlGen.