Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build type from WAR to JAR #14

Closed
wants to merge 1 commit into from

Conversation

gjwatts
Copy link
Member

@gjwatts gjwatts commented Oct 10, 2023

Currently, we are expecting a JAR format for the build files, so changing the type from WAR to JAR.

@gjwatts gjwatts requested a review from KyleAure October 10, 2023 23:24
@gjwatts gjwatts self-assigned this Oct 10, 2023
@@ -49,5 +49,5 @@ jobs:
uses: actions/upload-artifact@013d2b89baa2f354c5ffec54c68bec4ab39a2534 #v3.1.2
with:
name: Applications
path: io.openliberty.java.internal_fat_${{ matrix.java-version }}/build/libs/io.openliberty.java.internal_fat_${{ matrix.java-version }}.war
path: io.openliberty.java.internal_fat_${{ matrix.java-version }}/build/libs/io.openliberty.java.internal_fat_${{ matrix.java-version }}.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry looked at this again today and thought you were going the opposite direction (jar -> war).
You are building war files:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion Kyle, I did not properly explain what I am really after. I need a WAR file created, but I need it renamed to have a JAR file extension instead of a WAR file extension. When WAR files get uploaded to artifactory, they get renamed with JAR file extensions, but DHE does not do this. That is causing me a big headache to fix, so from now on I just want to have GHA build WAR files that are ostensibly JAR files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, well under the covers .war and .jar files are just compressed files (aka .zip).
So we could just add a step to the automation that can generate both :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants