24012 release prep #529
Merged
24012 release prep #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
mezarin
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Hi Adam, the changes look good.
I had a couple of comments and here are a couple more since there are no file changes for this:
- Update user-guide.xml:
software requirements-> IDE->table section-> Add new support. - Update installation.md:
Install New Software-> Liner 38 and 46.
| <unit id="org.eclipse.swtbot.ide.feature.group" version="3.1.0.202106041005"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <repository location="https://download.eclipse.org/tools/cdt/releases/10.6"/> |
There was a problem hiding this comment.
Have you thought about upgrading the CDT release version to https://download.eclipse.org/tools/cdt/releases/10.6. The current one is 2 years old.
Similarly: Consider updating this also to: https://download.eclipse.org/technology/swtbot/releases/4.2.1/. The one we are using is 3 years old.
These are just examples. But you should also consider updating lsp4mp, etc.
| @@ -24,7 +24,7 @@ | |||
| <parent> | |||
| <groupId>io.openliberty.tools.eclipse</groupId> | |||
| <artifactId>parent</artifactId> | |||
| <version>24.0.9-SNAPSHOT</version> | |||
| <version>24.0.12-SNAPSHOT</version> | |||
mezarin
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.