-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mp metrics2x #84
Mp metrics2x #84
Conversation
Merge qa to master: update feature version
|
Addressed review feedback. We need to have the same name and description for the tagged annotation to work. We can't change the descriptions as suggested, unless they're the same. @gkwan-ibm can you review again? Thank you. |
@Channyboy Hi David, can you help SME review the changes make to update the metrics guide to mpMetrics-2.0? Detail changes described in the PR description. Thank you. |
@yeekangc Can you review this PR as well pls? Thank you. |
Updated Liberty vendor doc link to the online doc, as OpenLiberty/docs#684 is being worked on already. |
* simplified pom and tests * Update MetricsIT with proper metric names and devmode test cases * fix gauge metric spelling * fix license years * add predefined server.xml * fix hotspots for MetricsIT * use JUnit5 * Modified description of MetricsIT test cases in README
Merged to |
Update guide to mpMetrics-2.0 according to issues raised in OpenLiberty/guides-common#224, #50.
Specific changes:
@Gauged
,@Counted
and some base metric outputs@Countered
annotation description to be counting monotonically upwards only@Timed
annotation to demonstrate multi-dimension metricsstart
directory