Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mp metrics2x #84

Merged
merged 14 commits into from
Nov 1, 2019
Merged

Mp metrics2x #84

merged 14 commits into from
Nov 1, 2019

Conversation

evelinec
Copy link
Contributor

@evelinec evelinec commented Sep 27, 2019

Update guide to mpMetrics-2.0 according to issues raised in OpenLiberty/guides-common#224, #50.

Specific changes:

  • Updated metric outputs where the formats are different, ie, @Gauged, @Counted and some base metric outputs
  • Added Liberty vendor metrics
  • Updated @Countered annotation description to be counting monotonically upwards only
  • Added tags for the @Timed annotation to demonstrate multi-dimension metrics
  • Added description of the multi-dimension metrics with tag and updated guide accordingly
  • Updated the start directory

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Oct 3, 2019

  • suggest the description of @Timed of get()
    description = "Time needed to get the properties of a system"

  • suggest the description of @Timed of list()
    description = "Time needed to create an inventory list of systems"

  • the output from 90 to 97 can be better as

# TYPE application_inventoryProcessingTime_rate_per_second gauge
application_inventoryProcessingTime_rate_per_second{method="get"} 0.0019189661542898407
...
# TYPE application_inventoryProcessingTime_seconds summary
# HELP application_inventoryProcessingTime_seconds Time needed to get the properties of a system
application_inventoryProcessingTime_seconds_count{method="get"} 1
application_inventoryProcessingTime_seconds{method="get",quantile="0.5"} 0.127965469
...
# TYPE application_inventoryProcessingTime_rate_per_second gauge
application_inventoryProcessingTime_rate_per_second{method="list"} 0.0038379320982686884
...
# TYPE application_inventoryProcessingTime_seconds summary
# HELP application_inventoryProcessingTime_seconds Time needed to create an inventory list of systems
application_inventoryProcessingTime_seconds_count{method="list"} 2
application_inventoryProcessingTime_seconds{method="list",quantile="0.5"} 2.2185000000000002E-5
...

@evelinec
Copy link
Contributor Author

evelinec commented Oct 4, 2019

Addressed review feedback. We need to have the same name and description for the tagged annotation to work. We can't change the descriptions as suggested, unless they're the same.

@gkwan-ibm can you review again? Thank you.

@evelinec evelinec requested a review from Channyboy October 7, 2019 20:20
@evelinec
Copy link
Contributor Author

evelinec commented Oct 7, 2019

@Channyboy Hi David, can you help SME review the changes make to update the metrics guide to mpMetrics-2.0? Detail changes described in the PR description. Thank you.

README.adoc Show resolved Hide resolved
@evelinec evelinec requested a review from Channyboy October 8, 2019 17:44
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
@evelinec evelinec requested a review from Channyboy October 10, 2019 17:48
README.adoc Outdated Show resolved Hide resolved
@evelinec evelinec requested a review from yeekangc October 25, 2019 18:04
@evelinec
Copy link
Contributor Author

@yeekangc Can you review this PR as well pls? Thank you.

@evelinec
Copy link
Contributor Author

Updated Liberty vendor doc link to the online doc, as OpenLiberty/docs#684 is being worked on already.

* simplified pom and tests

* Update MetricsIT with proper metric names and devmode test cases

* fix gauge metric spelling

* fix license years

* add predefined server.xml

* fix hotspots for MetricsIT

* use JUnit5

* Modified description of MetricsIT test cases in README
@evelinec
Copy link
Contributor Author

evelinec commented Nov 1, 2019

Merged to QA.

@evelinec evelinec merged commit 966a020 into qa Nov 1, 2019
gkwan-ibm added a commit that referenced this pull request Mar 2, 2020
@gkwan-ibm gkwan-ibm deleted the mpMetrics2x branch May 29, 2020 20:46
@gkwan-ibm gkwan-ibm mentioned this pull request Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants