-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Injection error fix #154
base: staging
Are you sure you want to change the base?
Injection error fix #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried out the guide from the start
directory, changes look good and remove mentioned error. But there are some README changes I think should be made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following error appears because code from the finish directory was in the start directory. The
Email
config was injected intoSystemConfig
before being created.[INFO] [ERROR ] CWMCG5003E: The [BackedAnnotatedField] @Inject @ConfigProperty private io.openliberty.guides.system.SystemConfig.email InjectionPoint dependency was not resolved. Error: java.util.NoSuchElementException: CWMCG0015E: The property io_openliberty_guides_email was not found in the configuration. [INFO] at com.ibm.ws.microprofile.config.impl.AbstractConfig.getValue(AbstractConfig.java:175) [INFO] at [internal classes]
Changed the starting files to remove the error that appears after running
mvn liberty:dev
and added instructions in the guide to add the injections back into theSystemConfig.java
andSystemResource.java
files.