Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injection error fix #154

Open
wants to merge 24 commits into
base: staging
Choose a base branch
from
Open

Injection error fix #154

wants to merge 24 commits into from

Conversation

tt-le
Copy link
Contributor

@tt-le tt-le commented Oct 19, 2020

The following error appears because code from the finish directory was in the start directory. The Email config was injected into SystemConfig before being created.

[INFO] [ERROR   ] CWMCG5003E: The [BackedAnnotatedField] @Inject @ConfigProperty private io.openliberty.guides.system.SystemConfig.email InjectionPoint dependency was not resolved. Error: java.util.NoSuchElementException: CWMCG0015E: The property io_openliberty_guides_email was not found in the configuration.
[INFO] 	at com.ibm.ws.microprofile.config.impl.AbstractConfig.getValue(AbstractConfig.java:175)
[INFO] 	at [internal classes]

Changed the starting files to remove the error that appears after running mvn liberty:devand added instructions in the guide to add the injections back into the SystemConfig.java and SystemResource.java files.

@tt-le tt-le marked this pull request as ready for review October 19, 2020 20:51
@AustinSeto AustinSeto changed the base branch from master to qa October 21, 2020 13:53
Copy link
Contributor

@AustinSeto AustinSeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried out the guide from the start directory, changes look good and remove mentioned error. But there are some README changes I think should be made.

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@AustinSeto AustinSeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkwan-ibm gkwan-ibm changed the base branch from qa to master May 19, 2021 18:30
@gkwan-ibm gkwan-ibm changed the base branch from prod to staging May 19, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants