Skip to content

Commit

Permalink
Merge pull request #1761 from cherylking/bumpDerbyDep101710
Browse files Browse the repository at this point in the history
Update derby dependency and affected test cases
  • Loading branch information
cherylking authored Nov 28, 2023
2 parents 21fd74f + 7125784 commit d95f046
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<dependency>
<groupId>org.apache.derby</groupId>
<artifactId>derby</artifactId>
<version>10.15.2.0</version>
<version>10.17.1.0</version>
<scope>provided</scope>
</dependency>
</dependencies>
Expand Down Expand Up @@ -99,7 +99,7 @@
<dependency>
<groupId>org.apache.derby</groupId>
<artifactId>derbyclient</artifactId>
<version>10.15.2.0</version>
<version>10.17.1.0</version>
</dependency>
</copyDependencies>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,19 +87,19 @@ public void testCopyDependenciesFilesExist() throws Exception {
Assert.assertFalse(f.getCanonicalFile() + " exists", f.exists());

// This was not defined in the dependencies and should not be copied.
f = new File("liberty/usr/shared/resources/derbytools-10.15.2.0.jar");
f = new File("liberty/usr/shared/resources/derbytools-10.17.1.0.jar");
Assert.assertFalse(f.getCanonicalFile() + " exists", f.exists());

// This was not defined in the dependencies and should be copied because the full GAV coordinate was specified.
f = new File("liberty/usr/shared/resources/derbyclient-10.15.2.0.jar");
f = new File("liberty/usr/shared/resources/derbyclient-10.17.1.0.jar");
Assert.assertTrue(f.getCanonicalFile() + " doesn't exist", f.exists());

// This was SCOPE_PROVIDED and should be copied.
f = new File("liberty/usr/shared/resources/derby-10.15.2.0.jar");
f = new File("liberty/usr/shared/resources/derby-10.17.1.0.jar");
Assert.assertTrue(f.getCanonicalFile() + " doesn't exist", f.exists());

// This is a transitive dependency of org.apache.derby:derby and should be copied.
f = new File("liberty/usr/shared/resources/derbyshared-10.15.2.0.jar");
f = new File("liberty/usr/shared/resources/derbyshared-10.17.1.0.jar");
Assert.assertTrue(f.getCanonicalFile() + " doesn't exist", f.exists());

}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@
<dependency>
<groupId>org.apache.derby</groupId>
<artifactId>derby</artifactId>
<version>10.15.2.0</version>
<version>10.17.1.0</version>
</dependency>
<dependency>
<groupId>org.apache.derby</groupId>
<artifactId>derbyclient</artifactId>
<version>10.15.2.0</version>
<version>10.17.1.0</version>
</dependency>
<dependency>
<groupId>commons-logging</groupId>
Expand Down Expand Up @@ -104,7 +104,7 @@
<dependency>
<groupId>org.apache.derby</groupId>
<artifactId>derbywar</artifactId>
<version>10.15.2.0</version>
<version>10.17.1.0</version>
<type>war</type>
</dependency>
</dependencyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public void testCopyDependenciesFilesExist() throws Exception {
Assert.assertTrue(f.getCanonicalFile() + " doesn't exist", f.exists());

// The next dependency specified the full GAV plus type `war`. The default location was used.
f = new File("liberty/usr/servers/test/lib/global/derbywar-10.15.2.0.war");
f = new File("liberty/usr/servers/test/lib/global/derbywar-10.17.1.0.war");
Assert.assertTrue(f.getCanonicalFile() + " doesn't exist", f.exists());
}
}
2 changes: 1 addition & 1 deletion liberty-maven-plugin/src/it/preserve-usr-dir-it/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<artifactItem>
<groupId>org.apache.derby</groupId>
<artifactId>derby</artifactId>
<version>10.13.1.1</version>
<version>10.17.1.0</version>
<outputDirectory>${project.build.directory}/liberty/wlp/usr/shared/resources</outputDirectory>
</artifactItem>
</artifactItems>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

public class CheckSharedResourceExistsIT {

public final String DERBY_RESOURCE = "target/liberty/wlp/usr/shared/resources/derby-10.13.1.1.jar";
public final String DERBY_RESOURCE = "target/liberty/wlp/usr/shared/resources/derby-10.17.1.0.jar";

@Test
public void testDerbyExists() throws Exception {
Expand Down

0 comments on commit d95f046

Please sign in to comment.