Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start parsing platforms, along with features in featureManager node #450

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

cbridgha
Copy link
Member

@cbridgha cbridgha commented Aug 28, 2024

The parsing logic now collects <platform> elements along with <features>

Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume more changes are coming to use the platforms when installing the features?

Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should not merge this PR before getting good builds in ci.maven and ci.gradle pointing to this branch though.

@cherylking cherylking requested a review from mattbsox September 12, 2024 17:12
@cherylking cherylking merged commit cd06f94 into OpenLiberty:main Sep 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants