Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Variable Processing #442

Closed
wants to merge 17 commits into from
Closed

Conversation

dshimo
Copy link
Contributor

@dshimo dshimo commented Feb 27, 2024

#126

  • Check compatibility with Maven and Gradle

Maven: https://github.com/dshimo/ci.maven/actions/runs/8377634883
Gradle: https://github.com/dshimo/ci.gradle/actions/runs/8442718868

Tests

  • var extraction
    • +: server.xml; boostrap.properties; server.env;
    • -: jvm.options; CLI
  • overrides on each level
  • overall procedure check
  • server.env additional file locations
  • jvm.options additional file locations
  • environment variable variations lookup
  • variables directory
  • bootstrap.include (Document link)

Config File Precedence (additional file location support)

  • server.env
  • jvm.options

New Features

  • environment variable variations lookup
    • 3 step lookup
    • lists()
    • Simple arithmetic
  • variables directory
  • bootstrap.include

Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only looked at code changes at this point, and not the tests.

@dshimo dshimo requested a review from cherylking March 12, 2024 20:57
@dshimo dshimo marked this pull request as ready for review March 12, 2024 20:57
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to review the test case and all the test case resources, but I wanted you to have my feedback/questions on the code itself. Sorry it has taken me this long. Crazy busy week.

Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests are good, but it was hard to know for sure. More comments would be great anywhere that you are verifying precedence (explaining where a particular variable was defined and overridden and the various values associated with it).

@dshimo dshimo requested a review from cherylking March 26, 2024 20:51
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple small comments to address

@cherylking
Copy link
Member

Superseded by #462.

@cherylking cherylking closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants