-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Variable Processing #442
Conversation
src/test/java/io/openliberty/tools/common/config/ServerConfigDocumentTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/openliberty/tools/common/config/ServerConfigDocumentTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/openliberty/tools/common/config/ServerConfigDocumentTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only looked at code changes at this point, and not the tests.
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to review the test case and all the test case resources, but I wanted you to have my feedback/questions on the code itself. Sorry it has taken me this long. Crazy busy week.
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/VariableUtility.java
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/VariableUtility.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tests are good, but it was hard to know for sure. More comments would be great anywhere that you are verifying precedence (explaining where a particular variable was defined and overridden and the various values associated with it).
src/test/java/io/openliberty/tools/common/config/ServerConfigDocumentOverridesTest.java
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/VariableUtility.java
Show resolved
Hide resolved
src/test/java/io/openliberty/tools/common/config/ServerConfigDocumentOverridesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/openliberty/tools/common/config/ServerConfigDocumentOverridesTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple small comments to address
Superseded by #462. |
#126
Maven: https://github.com/dshimo/ci.maven/actions/runs/8377634883
Gradle: https://github.com/dshimo/ci.gradle/actions/runs/8442718868
Tests
Config File Precedence (additional file location support)
New Features