Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly sort dir files alphabetically to match Liberty behavior #429

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

evie-lau
Copy link
Member

@evie-lau evie-lau commented Nov 3, 2023

  • Use case-insensitive sort for dir files to match Liberty behavior.
  • Fix configDropins processing to sort alphabetically
  • Simplified and refactored some code.

Current 23.0.0.10 release has a bug where it uses case-sensitive sort for <include> dirs.
Fix in open-liberty went in recently, and will be in the 23.0.0.12 release

@evie-lau evie-lau requested a review from cherylking November 3, 2023 16:52
@evie-lau evie-lau changed the title Correctly sort alphabetically to match Liberty behavior Correctly sort dir files alphabetically to match Liberty behavior Nov 3, 2023
@cherylking
Copy link
Member

Please build/run the tests for LMP and LGP with this branch and confirm none of the tests need updating since it is a change in behavior (even though it was a bug and incorrect behavior before). TIA

@evie-lau
Copy link
Member Author

LMP/LGP builds passed with these changes included.
Used the same build commands as what runs in Github Actions

mvn -V verify --batch-mode --no-transfer-progress --errors -DtrimStackTrace=false -Ponline-its -D"invoker.streamLogsOnFailures"=true -Druntime=ol -DruntimeVersion=23.0.0.10

gradle clean install check -P"test.exclude"="**/TestSpringBootApplication30*,**/DevContainerTest*" -Druntime=ol -DruntimeVersion=23.0.0.10 --stacktrace --i

@evie-lau evie-lau merged commit 653a3be into OpenLiberty:main Nov 15, 2023
8 checks passed
@evie-lau evie-lau deleted the fixDirParsing branch December 5, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants