-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide better error message for prepare feature #415
Conversation
src/main/java/io/openliberty/tools/common/plugins/util/PrepareFeatureUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/PrepareFeatureUtil.java
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/PrepareFeatureUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/PrepareFeatureUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/PrepareFeatureUtil.java
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/PrepareFeatureUtil.java
Outdated
Show resolved
Hide resolved
Updated error message:
If there's error in features-bom file:
If features-bom missing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the suggestion I made, which is what my previous comments were about. If it is not appropriate to issue that message when generatedJson does not exist, please add a comment to the code that explains why. Thanks.
Addressing OpenLiberty/ci.maven#1615.
Provide better error message when prepare-feature or prepareFeature task failed to generate
features.json
file for user feature(s).In most cases, errors are caused by missing artifact properties in
features-bom
file (ex.<type>esa</type>
) or wrong coordinates infeature-A.esa.pom
, if it exists. If there is a pom file for the feature esa file, then it will read the pom file first and check if the esa exists in specified cooridinate. If the pom file doesn't exist, then it will directly check the esa file specified infeatures-bom
file.