Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SELV3-793: use EXTERNAL_DOMAINS env variable and dynamically include … #29

Merged
merged 1 commit into from
Jan 10, 2025
Merged

SELV3-793: use EXTERNAL_DOMAINS env variable and dynamically include … #29

merged 1 commit into from
Jan 10, 2025

Conversation

olewandowski1
Copy link
Contributor

@olewandowski1 olewandowski1 commented Jan 10, 2025 •
edited by jira bot
Loading

…domains in csp

SELV3-793

Changes:
-App will dynamically include domains in the CSP header (based on EXTERNAL_DOMAINS env variable).

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

DominikNoga
DominikNoga approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@DominikNoga DominikNoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@olewandowski1 olewandowski1 merged commit 00a43d4 into master Jan 10, 2025
5 checks passed
@olewandowski1 olewandowski1 deleted the feature/SELV3-793 branch January 10, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikNoga DominikNoga DominikNoga approved these changes

@saleksandra saleksandra Awaiting requested review from saleksandra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olewandowski1 @DominikNoga